From: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
eitan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org
Subject: Re: [PATCH rdma-next V2 03/10] IB/core: Add subnet prefix to port info
Date: Tue, 8 Mar 2016 20:04:28 +0200 [thread overview]
Message-ID: <20160308180428.GD33629@x-vnc01.mtx.labs.mlnx> (raw)
In-Reply-To: <20160308175752.GD10805-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On Tue, Mar 08, 2016 at 10:57:52AM -0700, Jason Gunthorpe wrote:
>
> Looks reasonable
>
> Are you going to still send the mlx4/5 changes to avoid the other
> callback?
I don't think it is necessary since the hardware driver will do the
same thing to obtain the subnet prefix so I don't think it has any
siginficant benefit.
>
> Reviewed-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
>
Thanks
> > +++ b/include/rdma/ib_verbs.h
> > @@ -509,6 +509,7 @@ struct ib_port_attr {
> > u8 active_width;
> > u8 active_speed;
> > u8 phys_state;
> > + u64 subnet_prefix;
> > };
>
> This turned out to be aligned then?
>
Actually I missed this comment of yours. I will fix that as well.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-08 18:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 16:36 [PATCH rdma-next V2 00/10] IB SR-IOV support Eli Cohen
[not found] ` <1457455018-17638-1-git-send-email-eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-03-08 16:36 ` [PATCH rdma-next V2 01/10] net/core: Add support for configuring VF GUIDs Eli Cohen
2016-03-08 16:36 ` [PATCH rdma-next V2 02/10] IB/mlx5: Fix decision on using MAD_IFC Eli Cohen
2016-03-08 16:36 ` [PATCH rdma-next V2 03/10] IB/core: Add subnet prefix to port info Eli Cohen
[not found] ` <1457455018-17638-4-git-send-email-eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-03-08 17:57 ` Jason Gunthorpe
[not found] ` <20160308175752.GD10805-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-03-08 18:04 ` Eli Cohen [this message]
2016-03-08 16:36 ` [PATCH rdma-next V2 04/10] IB/core: Support accessing SA in virtualized environment Eli Cohen
2016-03-08 16:36 ` [PATCH rdma-next V2 05/10] IB/core: Add interfaces to control VF attributes Eli Cohen
2016-03-08 16:36 ` [PATCH rdma-next V2 06/10] IB/ipoib: Add ndo operations for configuring VFs Eli Cohen
2016-03-08 16:36 ` [PATCH rdma-next V2 07/10] net/mlx5_core: Add VF param when querying vport counter Eli Cohen
2016-03-08 16:36 ` [PATCH rdma-next V2 08/10] net/mlx5_core: Implement modify HCA vport command Eli Cohen
2016-03-08 16:36 ` [PATCH rdma-next V2 09/10] IB/mlx5: Implement callbacks for manipulating VFs Eli Cohen
2016-03-08 16:36 ` [PATCH rdma-next V2 10/10] IB/ipoib: Allow mcast packets from other VFs Eli Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160308180428.GD33629@x-vnc01.mtx.labs.mlnx \
--to=eli-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=eitan-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=liranl-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox