public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Parav Pandit <pandit.parav@gmail.com>
Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
	lizefan@huawei.com, Johannes Weiner <hannes@cmpxchg.org>,
	Doug Ledford <dledford@redhat.com>,
	Liran Liss <liranl@mellanox.com>,
	"Hefty, Sean" <sean.hefty@intel.com>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Haggai Eran <haggaie@mellanox.com>,
	Jonathan Corbet <corbet@lwn.net>,
	james.l.morris@oracle.com, serge@hallyn.com,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Matan Barak <matanb@mellanox.com>,
	akpm@linux-foundation.org, linux-security-module@vger.kernel.org
Subject: Re: [PATCHv10 1/3] rdmacg: Added rdma cgroup controller
Date: Tue, 5 Apr 2016 10:07:04 -0400	[thread overview]
Message-ID: <20160405140704.GC7822@mtj.duckdns.org> (raw)
In-Reply-To: <20160405140107.GB7822@mtj.duckdns.org>

Just one more thing.

On Tue, Apr 05, 2016 at 10:01:07AM -0400, Tejun Heo wrote:
...
> > pool_info in spin lock context, made me allocate memory to get all
> > values upfront through allocation.
> > Now that the lock is going away, I can do what you have described above.

So, this might be okay depending on the use case but it often becomes
painful to require sleeping context for freeing resources.  If you're
certain that requiring sleeping context is okay for all paths, using a
single mutex is fine but *usually* it isn't a great idea.

Thanks.

-- 
tejun

  reply	other threads:[~2016-04-05 14:07 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 20:22 [PATCHv10 0/3] rdmacg: IB/core: rdma controller support Parav Pandit
     [not found] ` <1458850962-16057-1-git-send-email-pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-24 20:22   ` [PATCHv10 1/3] rdmacg: Added rdma cgroup controller Parav Pandit
     [not found]     ` <1458850962-16057-2-git-send-email-pandit.parav-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-04-04 19:36       ` Tejun Heo
     [not found]         ` <20160404193640.GA7822-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-04-04 22:50           ` Parav Pandit
2016-04-05  1:25             ` Tejun Heo
2016-04-05  2:22               ` Parav Pandit
2016-04-05 14:01                 ` Tejun Heo
2016-04-05 14:07                   ` Tejun Heo [this message]
2016-04-05 14:14                     ` Parav Pandit
     [not found]                   ` <20160405140107.GB7822-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-04-05 14:25                     ` Parav Pandit
     [not found]                       ` <CAG53R5V=-sRacw7kX-UhjRmr+LS3HF4u8yfQF16utAxo-YHnMw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-05 14:46                         ` Tejun Heo
2016-04-05  9:06               ` Christoph Hellwig
     [not found]                 ` <20160405090627.GA26425-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-05 12:39                   ` Parav Pandit
2016-04-05 12:42                     ` Christoph Hellwig
     [not found]                       ` <20160405124252.GA4348-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-04-05 12:55                         ` Parav Pandit
2016-04-05 15:44                           ` Leon Romanovsky
2016-04-05 17:27                           ` Christoph Hellwig
2016-04-19  8:56                             ` Parav Pandit
2016-03-24 20:22 ` [PATCHv10 2/3] IB/core: added support to use " Parav Pandit
2016-03-24 20:22 ` [PATCHv10 3/3] rdmacg: Added documentation for rdmacg Parav Pandit
  -- strict thread matches above, loose matches on Subject: below --
2016-06-03 10:56 [PATCHv10 1/3] rdmacg: Added rdma cgroup controller Parav Pandit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160405140704.GC7822@mtj.duckdns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=dledford@redhat.com \
    --cc=haggaie@mellanox.com \
    --cc=hannes@cmpxchg.org \
    --cc=james.l.morris@oracle.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=liranl@mellanox.com \
    --cc=lizefan@huawei.com \
    --cc=matanb@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=pandit.parav@gmail.com \
    --cc=sean.hefty@intel.com \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox