From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Christoph Hellwig <hch@lst.de>,
dledford@redhat.com, bart.vanassche@sandisk.com,
swise@opengridcomputing.com, linux-rdma@vger.kernel.org,
target-devel@vger.kernel.org
Subject: Re: [PATCH 11/12] IB/core: add RW API support for signature MRs
Date: Tue, 19 Apr 2016 11:26:27 -0600 [thread overview]
Message-ID: <20160419172627.GC20844@obsidianresearch.com> (raw)
In-Reply-To: <57163E99.8090301@grimberg.me>
On Tue, Apr 19, 2016 at 05:20:09PM +0300, Sagi Grimberg wrote:
> In isert if the we have a single sg entry, we use the local_dma_lkey
> just so we can skip a registration (also for protection sg), perhaps
> rdma_rw_init_one_mr can do this optimization too?
Can't more than a single SG can be packed into a WR? Ideally this
common code should try and max out the SG entries before falling back
to using a WR?
There is probably an interesting performance trade off around making
the WR SG list bigger vs using the MR.
But that could be done as a follow up patch... This series is a big,
big improvement already.
Jason
next prev parent reply other threads:[~2016-04-19 17:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 20:14 generic RDMA READ/WRITE API V7 Christoph Hellwig
[not found] ` <1461010463-6603-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-04-18 20:14 ` [PATCH 01/12] IB/mlx5: Expose correct max_sge_rd limit Christoph Hellwig
2016-04-18 20:14 ` [PATCH 07/12] IB/core: add a need_inval flag to struct ib_mr Christoph Hellwig
2016-04-18 20:14 ` [PATCH 02/12] IB/cma: pass the port number to ib_create_qp Christoph Hellwig
2016-04-18 20:14 ` [PATCH 03/12] IB/core: allow passing mapping an offset into the SG in ib_map_mr_sg Christoph Hellwig
2016-04-18 20:14 ` [PATCH 04/12] IB/core: add a helper to check for READ WITH INVALIDATE support Christoph Hellwig
2016-04-18 20:14 ` [PATCH 05/12] IB/core: refactor ib_create_qp Christoph Hellwig
2016-04-18 20:14 ` [PATCH 06/12] IB/core: add a simple MR pool Christoph Hellwig
2016-04-18 20:14 ` [PATCH 08/12] IB/core: generic RDMA READ/WRITE API Christoph Hellwig
2016-04-18 20:14 ` [PATCH 09/12] target: enhance and export target_alloc_sgl/target_free_sgl Christoph Hellwig
2016-04-19 14:11 ` Sagi Grimberg
2016-04-18 20:14 ` [PATCH 10/12] IB/srpt: convert to the generic RDMA READ/WRITE API Christoph Hellwig
2016-04-18 20:14 ` [PATCH 11/12] IB/core: add RW API support for signature MRs Christoph Hellwig
[not found] ` <1461010463-6603-12-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-04-19 14:20 ` Sagi Grimberg
2016-04-19 17:26 ` Jason Gunthorpe [this message]
[not found] ` <20160419172627.GC20844-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-04-19 18:29 ` Christoph Hellwig
[not found] ` <20160419182950.GC989-jcswGhMUV9g@public.gmane.org>
2016-04-19 18:46 ` Sagi Grimberg
[not found] ` <57163E99.8090301-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-19 18:27 ` Christoph Hellwig
2016-04-18 20:14 ` [PATCH 12/12] IB/isert: convert to the generic RDMA READ/WRITE API Christoph Hellwig
2016-04-19 14:23 ` Sagi Grimberg
-- strict thread matches above, loose matches on Subject: below --
2016-04-11 21:32 generic RDMA READ/WRITE API V6 Christoph Hellwig
2016-04-11 21:32 ` [PATCH 11/12] IB/core: add RW API support for signature MRs Christoph Hellwig
[not found] ` <1460410360-13104-12-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-04-22 21:53 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419172627.GC20844@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=bart.vanassche@sandisk.com \
--cc=dledford@redhat.com \
--cc=hch@lst.de \
--cc=linux-rdma@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=swise@opengridcomputing.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).