From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Or Gerlitz <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] IB/iser: fix max_sectors calculation
Date: Thu, 28 Apr 2016 10:28:02 -0600 [thread overview]
Message-ID: <20160428162802.GA29690@obsidianresearch.com> (raw)
In-Reply-To: <CAJ3xEMj-HX=dRe8zew3VDZ6X_oodzfxX8SwnROCh1T6cfVNTYg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, Apr 28, 2016 at 01:51:21PM +0300, Or Gerlitz wrote:
> On Thu, Apr 28, 2016 at 10:55 AM, Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org> wrote:
> > I haven't used that explicit language, but: go fuck yourself, seriously.
>
> Christoph, I wrote you on both cases this was a nit comment.
>
> I understand now that you are not willing to accept nits as feedback on
> your fixes, and that you are really nervous on me, happens.
I wondered when this would finally blow up..
I would also prefer the nit picking on commit language to stop. It is
not a welcoming environment for new contributors, and it is a pain to
those who are doing the bulk of the work.
Get Doug to fix stuff up to match your preferences or let it go.
It is *really* not OK to ask Sagi to not ack such commits when the
code is OK. Sagi is doing a fine job.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-04-28 16:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 21:06 [PATCH] IB/iser: fix max_sectors calculation Christoph Hellwig
[not found] ` <1461013588-8825-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-04-19 14:06 ` Sagi Grimberg
2016-04-27 15:45 ` Max Gurtovoy
2016-04-28 7:33 ` Or Gerlitz
2016-04-28 7:42 ` Or Gerlitz
[not found] ` <CAJ3xEMh1kd_tXVrS73j46ns5syrw2WDTovqVpP0snbLru_fbQw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-28 7:55 ` Christoph Hellwig
[not found] ` <20160428075508.GA18285-jcswGhMUV9g@public.gmane.org>
2016-04-28 10:51 ` Or Gerlitz
[not found] ` <CAJ3xEMj-HX=dRe8zew3VDZ6X_oodzfxX8SwnROCh1T6cfVNTYg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-28 16:28 ` Jason Gunthorpe [this message]
[not found] ` <20160428162802.GA29690-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-04-28 20:21 ` Or Gerlitz
[not found] ` <CAJ3xEMjFbtjD4mBHFcd8-msqATgtOpj-fsUh0P-8v1ZZekBXuA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-28 21:11 ` Jason Gunthorpe
2016-04-28 11:15 ` Sagi Grimberg
[not found] ` <5721F0E6.9030806-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-04-28 14:02 ` Or Gerlitz
[not found] ` <CAJ3xEMgEm4b5pgcjTD+DyafoZptUiqhp3pYkpKH3eUcNz8iPbw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-29 11:06 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428162802.GA29690@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).