From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] IB/iser: fix max_sectors calculation Date: Thu, 28 Apr 2016 15:11:50 -0600 Message-ID: <20160428211150.GA32359@obsidianresearch.com> References: <1461013588-8825-1-git-send-email-hch@lst.de> <20160428075508.GA18285@lst.de> <20160428162802.GA29690@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Or Gerlitz Cc: Christoph Hellwig , Sagi Grimberg , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On Thu, Apr 28, 2016 at 11:21:45PM +0300, Or Gerlitz wrote: > > I would also prefer the nit picking on commit language to stop. It is > > not a welcoming environment for new contributors, and it is a pain to > > those who are doing the bulk of the work. > > So you are a native English speaker that prefers to have commit > change-logs with spelling mistakes vs. see a nit reviewer comment > followed by a respin by the submitter? What I do care about is growing our community and drawing in more high quality contributions, so seeing good work derided with a bunch of ugly emails is far, far worse in my mind. I can read past a few minor capitalization, spelling and grammar errors in a commit, and will happily accept that to improve our community. As a native speaker, I can tell you that the tone of the last batch of emails you sent was very poor. Too accusatory and demanding for the level of nitpicking you were doing. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html