Re: [PATCH 0/6] IB/hfi1: Clean up char devs and destage driver

Doug Ledford
2016-05-13T20:55:26Z

[-- Attachment #1: Type: text/plain, Size: 2439 bytes --]

On 05/12/2016 01:27 PM, Dennis Dalessandro wrote:
> Based on feedback we have received during review of recent hfi1 driver patches
> [1] we have decided to go ahead and remove the driver specific character devices
> for the UI and snoop/diag. Furthermore we remove the EPROM specific code since
> we have discovered a way to do this sort of stuff from user space.
>
> This series also removes the multi-purpose hfi1 cdev. We still maintain a per
> hfi cdev (/dev/hfi1_x) but the /dev/hfi1 cdev has been removed.
>
> The write()/writev() problem [2] has been addressed in a patch series previously
> posted and resubmitted just prior to this.
>
> Since the hfi1 TODO file is complete and we have removed the parts of the code
> which have drawn the most ire from the community list we believe it is now fair
> to let the driver move out of staging and into the mainline. We will work with
> the community to get back the features that have been removed as separate
> patches that can be more easily reviewed and commented on.
>
> We realize there is still an on-going effort to redo the verbs uAPI and
> understand that may have an impact on our use of the /dev/hfi1_x cdevs and are
> looking forward to working with the community on that front. However we do not
> believe that alone should hold the hfi1 driver in staging.
>
> There is one other aspect that has been called out, which is the
> driver's use of twsi code. We are currently working on a patch set to address
> that which will hopefully be out soon, but want to get this on the mailing list
> for comments rather than wait.
>
> [1] https://www.spinics.net/lists/linux-rdma/msg35319.html
> [2] https://www.spinics.net/lists/linux-rdma/msg34451.html
>
> This patch series applies on Doug's k.o/for-4.7 branch.
>
> Patches can also be viewed in my repo at:
> https://github.com/ddalessa/kernel/tree/for-4.7
>
> ---
>
> Dennis Dalessandro (6):
> IB/hfi1: Remove multiple device cdev
> IB/hfi1: Remove UI char device
> IB/hfi1: Remove EPROM functionality from data device
> IB/hfi1: Remove snoop/diag interface
> IB/hfi1: Remove anti-pattern in cdev init
> IB/hfi1: Move driver out of staging

I've delayed this until after the respin of this and the ioctl switch
series.

--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: 0E572FDD

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]