From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH 1/3] ib core: Make device counter infrastructure dynamic Date: Mon, 16 May 2016 12:06:09 -0600 Message-ID: <20160516180609.GC7248@obsidianresearch.com> References: <20160315155441.222586021@linux.com> <20160315155455.173645653@linux.com> <057c8ac8-1d34-e7b9-c0ad-91d805c81139@redhat.com> <041c6da0-e022-2bd1-5f00-e569c077e154@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Lameter Cc: Doug Ledford , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Bloch , Steve Wise , Majd Dibbiny , alonvi-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Mon, May 16, 2016 at 12:49:33PM -0500, Christoph Lameter wrote: > +char *names[] = { static const char * ? Isn't Kees trying to shift this sort of stuff to .rodata these days? > + "ipInReceives", [IPINRECEIVES] = "ipInReceives", Is probably more maintainable > + NULL [NR_COUNTERS] = NULL, Makes many of the BUILD_BUG_ON's redundant I think this is a fine idea, but I think we need to document the common set of counters and what it is they mean, otherwise it will just be chaos for userspace :( The MIB based counters and IBTA are already defined fortunately, just need to have common names. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html