Re: CQ and RDMA READ/WRITE APIs

Re: CQ and RDMA READ/WRITE APIs

[Christoph Hellwig]

Hi Linus,

we're not talking about a driver here - we're talking about a new API
lifted from a driver to generic code because it's commonly useful.

It's also in entirely new files and not a modification of existing code,
and it's always been clear how it is.  Some of the code has been in
since Linux 4.5 with a properly clear copyright.

I really don't understand Doug's objection, and as said if they have
a weird problem with it we can simply move it to a separate module.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: CQ and RDMA READ/WRITE APIs

[Christoph Lameter]

On Tue, 17 May 2016, Christoph Hellwig wrote:

> It's also in entirely new files and not a modification of existing code,
> and it's always been clear how it is.  Some of the code has been in
> since Linux 4.5 with a properly clear copyright.


The problem is that the RDMA subsystem is rather more than a driver. Its a
subsystem that contains drivers.  Dual licensed drivers can use the
features that Christoph provides. This is more infrastructure and thus GPL
I thought.

Re: CQ and RDMA READ/WRITE APIs

[Bart Van Assche]

On 05/16/2016 11:23 AM, Doug Ledford wrote:
> In this particular case, the dual license is used by the OpenFabrics
> Alliance.  They strip the RDMA stack in the kernel down to just the RDMA
> stack files and ship those separate from the rest of the kernel, along
> with the necessary user space stuff, and put the entire compilation
> under the same dual GPL/BSD license.  That's what their OFED product is.
>
> As I understand it, members of the OFA (Intel, Mellanox, Chelsio, etc.)
> actually signed an agreement as part of their membership entry into OFA
> that they would preserve that dual license when submitting code
> upstream.  This was originally intended to make sure that the stack as a
> whole could be used upstream, in distros, on switches, etc.  The idea
> being that a unified stack that could be copied around would enhance
> interoperability or something like that.
>
> I can't speak to how actively used it is any more.  I think maybe on
> switches or some other dedicated devices.  But, I was asked by the OFA
> to try and preserve it.
>
> In this particular case, Christoph wrote his code from scratch.  I'm not
> concerned with it.  It was never dual licensed and need not be.  But he
> did submit patches that modified existing dual license drivers to use
> his new code and removed their own implementation of the same thing in
> the process.  What used to be more or less functional drivers that could
> be copied and used elsewhere will no longer be able to be copied in the
> same way.  I'm just waiting for Sagi Grimberg to speak for iSER and for
> Bart van Assche to speak for SRP and let me know that they are OK with
> the change.  I think a patch set that will essentially change the
> licensing nature of their code should carry their explicit approval of
> the license change.

(+linux-rdma)

Hello Doug,

As far as I know SanDisk, a Western Digital Company, is fine with 
changing the license of the code under drivers/infiniband/ulp/srpt from 
dual licensed into GPL-only. However, if OFA members want that the 
entire RDMA core is dual licensed I think we will have to talk to Tejun:

$ PAGER= git grep EXPORT_SYMBOL_GPL drivers/infiniband/
drivers/infiniband/core/device.c:EXPORT_SYMBOL_GPL(ib_wq);

$ git show f06267104dd9112f11586830d22501d0e26245ea
commit f06267104dd9112f11586830d22501d0e26245ea
Author: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Date:   Tue Oct 19 15:24:36 2010 +0000

     RDMA: Update workqueue usage

[ ... ]
+struct workqueue_struct *ib_wq;
+EXPORT_SYMBOL_GPL(ib_wq);
[ ... ]

$ PAGER= git grep -lw ib_wq drivers/infiniband/
drivers/infiniband/core/cache.c
drivers/infiniband/core/device.c
drivers/infiniband/core/roce_gid_mgmt.c
drivers/infiniband/core/sa_query.c
drivers/infiniband/core/umem.c
drivers/infiniband/hw/qib/qib_iba7220.c
drivers/infiniband/hw/qib/qib_iba7322.c
drivers/infiniband/hw/qib/qib_init.c

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: CQ and RDMA READ/WRITE APIs

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 3500 bytes --]

On 05/17/2016 01:29 PM, Bart Van Assche wrote:
> On 05/16/2016 11:23 AM, Doug Ledford wrote:
>> In this particular case, the dual license is used by the OpenFabrics
>> Alliance.  They strip the RDMA stack in the kernel down to just the RDMA
>> stack files and ship those separate from the rest of the kernel, along
>> with the necessary user space stuff, and put the entire compilation
>> under the same dual GPL/BSD license.  That's what their OFED product is.
>>
>> As I understand it, members of the OFA (Intel, Mellanox, Chelsio, etc.)
>> actually signed an agreement as part of their membership entry into OFA
>> that they would preserve that dual license when submitting code
>> upstream.  This was originally intended to make sure that the stack as a
>> whole could be used upstream, in distros, on switches, etc.  The idea
>> being that a unified stack that could be copied around would enhance
>> interoperability or something like that.
>>
>> I can't speak to how actively used it is any more.  I think maybe on
>> switches or some other dedicated devices.  But, I was asked by the OFA
>> to try and preserve it.
>>
>> In this particular case, Christoph wrote his code from scratch.  I'm not
>> concerned with it.  It was never dual licensed and need not be.  But he
>> did submit patches that modified existing dual license drivers to use
>> his new code and removed their own implementation of the same thing in
>> the process.  What used to be more or less functional drivers that could
>> be copied and used elsewhere will no longer be able to be copied in the
>> same way.  I'm just waiting for Sagi Grimberg to speak for iSER and for
>> Bart van Assche to speak for SRP and let me know that they are OK with
>> the change.  I think a patch set that will essentially change the
>> licensing nature of their code should carry their explicit approval of
>> the license change.
> 
> (+linux-rdma)
> 
> Hello Doug,
> 
> As far as I know SanDisk, a Western Digital Company, is fine with
> changing the license of the code under drivers/infiniband/ulp/srpt from
> dual licensed into GPL-only. However, if OFA members want that the
> entire RDMA core is dual licensed I think we will have to talk to Tejun:
> 
> $ PAGER= git grep EXPORT_SYMBOL_GPL drivers/infiniband/
> drivers/infiniband/core/device.c:EXPORT_SYMBOL_GPL(ib_wq);
> 
> $ git show f06267104dd9112f11586830d22501d0e26245ea
> commit f06267104dd9112f11586830d22501d0e26245ea
> Author: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Date:   Tue Oct 19 15:24:36 2010 +0000
> 
>     RDMA: Update workqueue usage
> 
> [ ... ]
> +struct workqueue_struct *ib_wq;
> +EXPORT_SYMBOL_GPL(ib_wq);
> [ ... ]
> 
> $ PAGER= git grep -lw ib_wq drivers/infiniband/
> drivers/infiniband/core/cache.c
> drivers/infiniband/core/device.c
> drivers/infiniband/core/roce_gid_mgmt.c
> drivers/infiniband/core/sa_query.c
> drivers/infiniband/core/umem.c
> drivers/infiniband/hw/qib/qib_iba7220.c
> drivers/infiniband/hw/qib/qib_iba7322.c
> drivers/infiniband/hw/qib/qib_init.c

Nice catch there Bart.  That was well before my role as maintainer and
so settles things well enough for me.  IOW, I don't feel I need to worry
about trying to maintain the dual license nature of the RDMA stack as it
was broken long before I took over.  Thanks for pointing that out.


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

Re: CQ and RDMA READ/WRITE APIs

[Linus Torvalds]

On Tue, May 17, 2016 at 10:32 AM, Doug Ledford <dledford@redhat.com> wrote:
>
> Nice catch there Bart.  That was well before my role as maintainer and
> so settles things well enough for me.  IOW, I don't feel I need to worry
> about trying to maintain the dual license nature of the RDMA stack as it
> was broken long before I took over.  Thanks for pointing that out.

Ok, so it sounds like there isn't really a problem. Good.

              Linus

Re: CQ and RDMA READ/WRITE APIs

[Parav Pandit]

Hi Doug,

On Tue, May 17, 2016 at 11:02 PM, Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> Nice catch there Bart.  That was well before my role as maintainer and
> so settles things well enough for me.  IOW, I don't feel I need to worry
> about trying to maintain the dual license nature of the RDMA stack as it
> was broken long before I took over.  Thanks for pointing that out.
>

Does it mean we can submit new code files under GPL only license?
I submitted RDMA cgroup related code in ib_core under GPLv2 only license.
Existing files which are calling those new APIs will continue to be
dual license (similar to CQ and RDMA APIs)?

Parav
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: CQ and RDMA READ/WRITE APIs

[Doug Ledford]

[-- Attachment #1: Type: text/plain, Size: 1531 bytes --]

On 05/17/2016 10:48 PM, Parav Pandit wrote:
> Hi Doug,
> 
> On Tue, May 17, 2016 at 11:02 PM, Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>> Nice catch there Bart.  That was well before my role as maintainer and
>> so settles things well enough for me.  IOW, I don't feel I need to worry
>> about trying to maintain the dual license nature of the RDMA stack as it
>> was broken long before I took over.  Thanks for pointing that out.
>>
> 
> Does it mean we can submit new code files under GPL only license?

You always could.

> I submitted RDMA cgroup related code in ib_core under GPLv2 only license.

You did and you didn't.  For instance, in patch 1/3, the new
cgroup_rdma.c file has a notice of GPLv2, but no notice of copyright, so
it's incomplete.  You need to put a copyright notice in the file too.
And in the file cgroup_rdma.h you have neither a copyright notice or a
license statement.  It's a plain file.

In patch 2/3, the file infiniband/core/cgroup.c has a copied dual
license (not necessary, it can be GPL only), but again, it is missing
the copyright notice.

You need to finish the conversation you and Christoph were having in
that thread, but you also need a v11 of the patchset that fixes the
copyright issues.

> Existing files which are calling those new APIs will continue to be
> dual license (similar to CQ and RDMA APIs)?

Yes.


-- 
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
              GPG KeyID: 0E572FDD



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

Re: CQ and RDMA READ/WRITE APIs

[Parav Pandit]

On Wed, May 18, 2016 at 7:37 PM, Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
> On 05/17/2016 10:48 PM, Parav Pandit wrote:
>> Hi Doug,
>>
>> On Tue, May 17, 2016 at 11:02 PM, Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>>> Nice catch there Bart.  That was well before my role as maintainer and
>>> so settles things well enough for me.  IOW, I don't feel I need to worry
>>> about trying to maintain the dual license nature of the RDMA stack as it
>>> was broken long before I took over.  Thanks for pointing that out.
>>>
>>
>> Does it mean we can submit new code files under GPL only license?
>
> You always could.
>
>> I submitted RDMA cgroup related code in ib_core under GPLv2 only license.
>
> You did and you didn't.  For instance, in patch 1/3, the new
> cgroup_rdma.c file has a notice of GPLv2, but no notice of copyright, so
> it's incomplete.  You need to put a copyright notice in the file too.
> And in the file cgroup_rdma.h you have neither a copyright notice or a
> license statement.  It's a plain file.
>
> In patch 2/3, the file infiniband/core/cgroup.c has a copied dual
> license (not necessary, it can be GPL only), but again, it is missing
> the copyright notice.
>
ok. I will fix this part too in v11.

> You need to finish the conversation you and Christoph were having in
> that thread, but you also need a v11 of the patchset that fixes the
> copyright issues.
>
Yes. I will ping Christoph and Tejun as I am waiting for their responses.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html