From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>,
Mark Bloch <markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH v4] IB/core: Make device counter infrastructure dynamic
Date: Tue, 24 May 2016 11:25:51 -0600 [thread overview]
Message-ID: <20160524172551.GE8037@obsidianresearch.com> (raw)
In-Reply-To: <ecc98d137bffc959e6459d9ffd0fe53da0d84c9d.1463760487.git.dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On Fri, May 20, 2016 at 12:14:47PM -0400, Doug Ledford wrote:
> +static const char *names[] = {
What is wrong with
static const char * const names[] = {
As I originally suggested? No reason for the array to be .data that I
can see.
> + /* Guard against buggy edits of the names array */
> + BUILD_BUG_ON(ARRAY_SIZE(names) != NR_COUNTERS);
Just drop NR_COUNTERS an use ARRAY_SIZE(names) in all places
instead?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-05-24 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 16:14 [PATCH v4] IB/core: Make device counter infrastructure dynamic Doug Ledford
[not found] ` <ecc98d137bffc959e6459d9ffd0fe53da0d84c9d.1463760487.git.dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-05-20 16:53 ` Mark Bloch
[not found] ` <VI1PR05MB1391B8F7E83C21B653BC0C92D24B0-79XLn2atqDP8GeyK7vyn2tqRiQSDpxhJvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-05-20 18:43 ` Doug Ledford
2016-05-20 16:56 ` kbuild test robot
2016-05-20 17:07 ` Christoph Lameter
2016-05-24 17:25 ` Jason Gunthorpe [this message]
[not found] ` <20160524172551.GE8037-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-05-24 23:01 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160524172551.GE8037@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox