Re: [PATCH 10/10] IB/hfi1: Fix credit return threshold adjustment

[Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Wed, May 25, 2016 at 08:27:37AM -0700, Bart Van Assche wrote:
>On 05/25/2016 06:36 AM, Leon Romanovsky wrote:
>>On Tue, May 24, 2016 at 12:51:12PM -0700, Dennis Dalessandro wrote:
>>>@@ -1872,11 +1873,27 @@ int pio_map_init(struct hfi1_devdata *dd, u8 
>>>port, u8 num_vls, u8 *vl_scontexts)
>>>  			if (!newmap->map[i])
>>>  				goto bail;
>>>  			newmap->map[i]->mask = (1 << ilog2(sz)) - 1;
>>>-			/* assign send contexts */
>>>+			/*
>>>+			 * assign send contexts and
>>>+			 * adjust credit return threshold
>>>+			 */
>>>  			for (j = 0; j < sz; j++) {
>>>-				if (dd->kernel_send_context[scontext])
>>>+				if (dd->kernel_send_context[scontext]) {
>>>  					newmap->map[i]->ksc[j] =
>>>  					dd->kernel_send_context[scontext];
>>>+					thres = min(sc_percent_to_threshold(
>>>+						    dd->kernel_send_context
>>>+						    [scontext], 50),
>>>+						    sc_mtu_to_threshold(
>>>+						    dd->kernel_send_context
>>>+						    [scontext], 
>>>dd->vld[i].mtu,
>>>+						    
>>>dd->rcd[0]->rcvhdrqentsize)
>>>+						    );
>>>+					sc_set_cr_threshold(
>>>+						dd->
>>>+					 kernel_send_context[scontext],
>>
>>You took checkpatch warnings output to the extreme.
>
>Hello Dennis and Leon,
>
>Such formatting usually means that the indentation level is too deep. 
>One way to address this is to move the body of the for loop into a new 
>function. Choosing a shorter name for kernel_send_context and 
>introducing temporary variables for the results of 
>sc_percent_to_threshold(...) would also help.

Yeah, we sometimes take the checkpatch thing to the extreme. Problem is 
while we sit in staging the hfi1 driver is a big target for folks to send 
checkpatch type fixes. We try to prevent that when we can.

We'll take a stab at prettying this up and reducing the indentation level.

-Denny

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html