public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jarod Wilson <jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] Fix unused variable warnings for pl_index, sg_l
Date: Thu, 26 May 2016 08:08:26 +0300	[thread overview]
Message-ID: <20160526050826.GQ25500@leon.nu> (raw)
In-Reply-To: <1463591298-30102-1-git-send-email-jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 1265 bytes --]

On Wed, May 18, 2016 at 01:08:18PM -0400, Jarod Wilson wrote:
> These variables will be unused if certain #define's aren't set, so wrap
> them with the same #ifdef's as the places they're used.
> 
> Signed-off-by: Jarod Wilson <jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> ---
>  src/perftest_resources.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/perftest_resources.c b/src/perftest_resources.c
> index 71a1541..4071989 100755
> --- a/src/perftest_resources.c
> +++ b/src/perftest_resources.c
> @@ -2778,8 +2778,12 @@ int run_iter_bw(struct pingpong_context *ctx,struct perftest_parameters *user_pa
>  	int 			cpu_mhz = 0;
>  	int 			return_value = 0;
>  	int			wc_id;
> +	#ifdef HAVE_VERBS_EXP
> +	#ifdef HAVE_ACCL_VERBS

Maybe "#if defined(HAVE_VERBS_EXP) && defined(HAVE_ACCL_VERBS)" will be
better?

Anyway, it is the same.

>  	int pl_index;
>  	struct ibv_sge		*sg_l;
> +	#endif
> +	#endif
>  
>  	ALLOCATE(wc ,struct ibv_wc ,CTX_POLL_BATCH);
>  
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      parent reply	other threads:[~2016-05-26  5:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 17:08 [PATCH] Fix unused variable warnings for pl_index, sg_l Jarod Wilson
     [not found] ` <1463591298-30102-1-git-send-email-jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-05-26  5:08   ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160526050826.GQ25500@leon.nu \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox