On Tue, May 24, 2016 at 04:07:20PM -0600, Jason Gunthorpe wrote:
> On Tue, May 24, 2016 at 05:35:26PM +0300, Leon Romanovsky wrote:
> 
> > +	ucontext->device = ib_dev;
> > +	INIT_LIST_HEAD(&ucontext->pd_list);
> > +	INIT_LIST_HEAD(&ucontext->mr_list);
> > +	INIT_LIST_HEAD(&ucontext->mw_list);
> > +	INIT_LIST_HEAD(&ucontext->cq_list);
> > +	INIT_LIST_HEAD(&ucontext->qp_list);
> > +	INIT_LIST_HEAD(&ucontext->srq_list);
> > +	INIT_LIST_HEAD(&ucontext->ah_list);
> > +	INIT_LIST_HEAD(&ucontext->xrcd_list);
> > +	INIT_LIST_HEAD(&ucontext->rule_list);
> [..]
> 
> Please don't cut and paste like this.
> 
> Considering your approach I'd suggest just go ahead and immediately
> implement a compat wrapper for each replaced write() style call.
> 
> eg replace ib_uverbs_get_context with something that forms a
> new-style-command and calls the netlink version directly.
> 

Thank you and Sean for reviewing it.

We will do our best to address all comments from this discussion in our
next RFC version.