From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: leon@kernel.org, Max Gurtovoy <maxg@mellanox.com>,
matanb@mellanox.com, sagi@grimberg.me,
linux-rdma@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] IB/core: Fix different types mix in ib_device_cap_flags structure values
Date: Tue, 31 May 2016 12:16:19 -0600 [thread overview]
Message-ID: <20160531181619.GB21834@obsidianresearch.com> (raw)
In-Reply-To: <13f16fdf-e1d2-0baa-abe1-6423d2196b72@sandisk.com>
On Tue, May 31, 2016 at 11:05:00AM -0700, Bart Van Assche wrote:
> Let me rephrase my question. Before and after this patch
> IB_DEVICE_SG_GAPS_REG is defined as 1ULL << 32, so how can this patch make a
> difference?
Excellent question.
I thought the issue was this:
IB_DEVICE_ON_DEMAND_PAGING = (1 << 31),
Because (1<<31) is also technically undefined if 1 is signed, which,
IIRC, is a compiler choice.. But you are right, all the other ones
look OK.
Mellanox, so what does this *actually* do??
> And if the issue is that some compilers choose a 32-bit integer for
> ib_device_cap_flags and others a 64-bit integer, shouldn't
That isn't allowed by the standard. The compiler cannot truncate enum
values.
Jason
next prev parent reply other threads:[~2016-05-31 18:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 10:09 [PATCH] IB/core: Fix different types mix in ib_device_cap_flags structure values Max Gurtovoy
2016-05-31 15:36 ` Bart Van Assche
[not found] ` <4156c03f-4977-17eb-db64-6df775b6e592-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-05-31 19:14 ` Max Gurtovoy
[not found] ` <1464602994-21226-1-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-05-31 15:35 ` Bart Van Assche
2016-05-31 17:13 ` Jason Gunthorpe
[not found] ` <20160531171306.GA6618-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-05-31 17:30 ` Leon Romanovsky
[not found] ` <20160531173033.GC7477-2ukJVAZIZ/Y@public.gmane.org>
2016-05-31 18:05 ` Bart Van Assche
2016-05-31 18:12 ` Leon Romanovsky
[not found] ` <20160531181223.GE7477-2ukJVAZIZ/Y@public.gmane.org>
2016-05-31 18:21 ` Jason Gunthorpe
[not found] ` <20160531182100.GC21834-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-05-31 18:54 ` Leon Romanovsky
2016-05-31 19:39 ` Jason Gunthorpe
2016-06-01 12:04 ` Max Gurtovoy
[not found] ` <574ECF44.3070003-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-06-01 15:35 ` Sagi Grimberg
2016-05-31 18:43 ` Bart Van Assche
2016-05-31 18:16 ` Jason Gunthorpe [this message]
2016-05-31 19:16 ` Robert LeBlanc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160531181619.GB21834@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=bart.vanassche@sandisk.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox