From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH] IB/core: Fix bit curruption in ib_device_cap_flags structure Date: Thu, 2 Jun 2016 09:52:38 -0700 Message-ID: <20160602165238.GB30960@kroah.com> References: <1464859685-18666-1-git-send-email-maxg@mellanox.com> <20160602162426.GC26699@kroah.com> <575061A6.1060302@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <575061A6.1060302-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Max Gurtovoy Cc: matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, leon-2ukJVAZIZ/Y@public.gmane.org, sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robert-4JaGZRWAfWbajFs6igw21g@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Thu, Jun 02, 2016 at 07:41:10PM +0300, Max Gurtovoy wrote: > > > On 6/2/2016 7:24 PM, Greg KH wrote: > > On Thu, Jun 02, 2016 at 12:28:05PM +0300, Max Gurtovoy wrote: > > > ib_device_cap_flags 64-bit expansion caused caps overlapping > > > and made consumers read wrong device capabilities. For example > > > IB_DEVICE_SG_GAPS_REG was falsely read by the iser driver causing > > > it to use a non-existing capability. This happened because signed > > > int becomes sign extended when converted it to u64. Fix this by > > > casting IB_DEVICE_ON_DEMAND_PAGING enumeration to ULL. > > > > > > Fixes: fb532d6a79b9 ('IB/{core, ulp} Support above 32 possible device capability flags') > > > Reported-by: Robert LeBlanc > > > Cc: Stable #[v4.6+] > > > Acked-by: Sagi Grimberg > > > Signed-off-by: Max Gurtovoy > > > Signed-off-by: Matan Barak > > > --- > > > include/rdma/ib_verbs.h | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > > > index 432bed5..c97357b 100644 > > > --- a/include/rdma/ib_verbs.h > > > +++ b/include/rdma/ib_verbs.h > > > @@ -217,7 +217,7 @@ enum ib_device_cap_flags { > > > IB_DEVICE_CROSS_CHANNEL = (1 << 27), > > > IB_DEVICE_MANAGED_FLOW_STEERING = (1 << 29), > > > IB_DEVICE_SIGNATURE_HANDOVER = (1 << 30), > > > - IB_DEVICE_ON_DEMAND_PAGING = (1 << 31), > > > + IB_DEVICE_ON_DEMAND_PAGING = (1ULL << 31), > > > IB_DEVICE_SG_GAPS_REG = (1ULL << 32), > > > IB_DEVICE_VIRTUAL_FUNCTION = ((u64)1 << 33), > > > IB_DEVICE_RAW_SCATTER_FCS = ((u64)1 << 34), > > > > Why not just use the BIT() and BIT_ULL() macros instead of "open coding" > > these? > > Good idea. do you think it will be a good idea to set all the elements in > this ib_device_cap_flags enum to BIT_ULL() in this patch ? to have 1 style > instead of many ? Yes. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html