Re: [PATCH rdma-next 28/29] IB/rxe: Shared objects between user and kernel

Leon Romanovsky
2016-06-09T06:09:31Z

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]

On Thu, Jun 02, 2016 at 07:57:36PM +0300, Moni Shoua wrote:
> User and kernel pass objects in shared memeory. For this both sides need
> to declare about the layout of each object in memory or in other words:
> agree about the ABI.
>
> Signed-off-by: Kamal Heib <kamalh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Amir Vadai <amirv-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Moni Shoua <monis-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Reviewed-by: Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
> include/uapi/rdma/Kbuild | 1 +
> include/uapi/rdma/ib_rxe.h | 139 +++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 140 insertions(+)
> create mode 100644 include/uapi/rdma/ib_rxe.h
>
> diff --git a/include/uapi/rdma/Kbuild b/include/uapi/rdma/Kbuild
> index 231901b..94f9401 100644
> --- a/include/uapi/rdma/Kbuild
> +++ b/include/uapi/rdma/Kbuild
> @@ -6,3 +6,4 @@ header-y += ib_user_verbs.h
> header-y += rdma_netlink.h
> header-y += rdma_user_cm.h
> header-y += hfi/
> +header-y += ib_rxe.h

IMHO, it needs to be called ib_user_rxe.h and not ib_rxe.h
It looks like rdma_netlink.h is exclusion from that convention.

> diff --git a/include/uapi/rdma/ib_rxe.h b/include/uapi/rdma/ib_rxe.h
> new file mode 100644
> index 0000000..eb8ff8c
> --- /dev/null
> +++ b/include/uapi/rdma/ib_rxe.h
> @@ -0,0 +1,139 @@
> +/*
> + * Copyright (c) 2015 Mellanox Technologies Ltd. All rights reserved.

Small nitpick - need to update Copyright.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]