Re: [PATCH rdma-next 28/29] IB/rxe: Shared objects between user and kernel

Moni Shoua
2016-06-13T07:22:56Z

>> +header-y += ib_rxe.h
>
Right. I'll rename
> IMHO, it needs to be called ib_user_rxe.h and not ib_rxe.h
> It looks like rdma_netlink.h is exclusion from that convention.
>
>> diff --git a/include/uapi/rdma/ib_rxe.h b/include/uapi/rdma/ib_rxe.h
>> new file mode 100644
>> index 0000000..eb8ff8c
>> --- /dev/null
>> +++ b/include/uapi/rdma/ib_rxe.h
>> @@ -0,0 +1,139 @@
>> +/*
>> + * Copyright (c) 2015 Mellanox Technologies Ltd. All rights reserved.
>
> Small nitpick - need to update Copyright.
>
Done