From: Leon Romanovsky <leon-2ukJVAZIZ/Y@public.gmane.org>
To: Max Gurtovoy <maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org,
sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robert-4JaGZRWAfWbajFs6igw21g@public.gmane.org
Subject: Re: [PATCH] IB/core: Fix bit curruption in ib_device_cap_flags structure
Date: Fri, 3 Jun 2016 13:47:08 +0300 [thread overview]
Message-ID: <20160603104708.GL7477@leon.nu> (raw)
In-Reply-To: <1464859685-18666-1-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
On Thu, Jun 02, 2016 at 12:28:05PM +0300, Max Gurtovoy wrote:
> ib_device_cap_flags 64-bit expansion caused caps overlapping
> and made consumers read wrong device capabilities. For example
> IB_DEVICE_SG_GAPS_REG was falsely read by the iser driver causing
> it to use a non-existing capability. This happened because signed
> int becomes sign extended when converted it to u64. Fix this by
> casting IB_DEVICE_ON_DEMAND_PAGING enumeration to ULL.
>
> Fixes: fb532d6a79b9 ('IB/{core, ulp} Support above 32 possible device capability flags')
Everything fine, except this Fixes line, which is similar to the issue,
but unrelated. The sign extension error was produced after adding
bit(32) to the enum and the commit fb532d6a79b9 didn't do it and didn't
mean to do it.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-03 10:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 9:28 [PATCH] IB/core: Fix bit curruption in ib_device_cap_flags structure Max Gurtovoy
2016-06-02 11:33 ` Christoph Hellwig
[not found] ` <20160602113353.GA18494-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-06-02 11:48 ` Max Gurtovoy
2016-06-02 11:56 ` Sagi Grimberg
2016-06-02 16:51 ` Jason Gunthorpe
[not found] ` <1464859685-18666-1-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-06-02 16:24 ` Greg KH
2016-06-02 16:41 ` Max Gurtovoy
[not found] ` <575061A6.1060302-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-06-02 16:52 ` Greg KH
[not found] ` <20160602162426.GC26699-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-06-02 16:41 ` Bart Van Assche
[not found] ` <c72fac21-0a3d-fc40-ec82-e156f29c2fab-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-06-02 16:52 ` Greg KH
2016-06-02 16:48 ` Christoph Lameter
2016-06-03 10:47 ` Leon Romanovsky [this message]
2016-06-02 16:52 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603104708.GL7477@leon.nu \
--to=leon-2ukjvaziz/y@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=robert-4JaGZRWAfWbajFs6igw21g@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox