Re: [PATCH, RFC] mlx4_ib: Make steering support independent of MLX4_BMME_FLAG_TYPE_2_WIN

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

On Thu, Jun 02, 2016 at 11:18:19AM +0300, Leon Romanovsky wrote:
> On Wed, Jun 01, 2016 at 05:07:17PM -0700, Bart Van Assche wrote:
> > Hello,
> > 
> > Can anyone who is familiar with the mlx4 driver tell me whether or not
> > the patch below makes sense? I ran into this code by analyzing the mlx4
> > source code with smatch.
> 
> Hi Bart,
> Thank you bringing it to our attention. I had a fast chit-chat with
> Matan who was the last person who touched that area. It looks like an
> unharmful issue with the code, because we had support for memory window
> feature literally forever.

hi Bart,
Do you want us to handle this fix (improve title, fill commit message)?
Or maybe you prefer to submit it by yourself?

Thanks.

> 
> Thanks.
> 
> > 
> > Thanks,
> > 
> > Bart.
> > 
> > ---
> >  drivers/infiniband/hw/mlx4/main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
> > index b01ef6e..db7d0bc 100644
> > --- a/drivers/infiniband/hw/mlx4/main.c
> > +++ b/drivers/infiniband/hw/mlx4/main.c
> > @@ -505,9 +505,9 @@ static int mlx4_ib_query_device(struct ib_device *ibdev,
> >  			props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2B;
> >  		else
> >  			props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2A;
> > +	}
> >  	if (dev->steering_support ==  MLX4_STEERING_MODE_DEVICE_MANAGED)
> >  		props->device_cap_flags |= IB_DEVICE_MANAGED_FLOW_STEERING;
> > -	}
> >  
> >  	props->device_cap_flags |= IB_DEVICE_RAW_IP_CSUM;
> >  
> > -- 
> > 2.8.3
> > 



[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]