[PATCH, RFC] mlx4_ib: Make steering support independent of MLX4_BMME_FLAG_TYPE_2_WIN

[PATCH, RFC] mlx4_ib: Make steering support independent of MLX4_BMME_FLAG_TYPE_2_WIN

[Bart Van Assche]

Hello,

Can anyone who is familiar with the mlx4 driver tell me whether or not
the patch below makes sense? I ran into this code by analyzing the mlx4
source code with smatch.

Thanks,

Bart.

---
 drivers/infiniband/hw/mlx4/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
index b01ef6e..db7d0bc 100644
--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/main.c
@@ -505,9 +505,9 @@ static int mlx4_ib_query_device(struct ib_device *ibdev,
 			props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2B;
 		else
 			props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2A;
+	}
 	if (dev->steering_support ==  MLX4_STEERING_MODE_DEVICE_MANAGED)
 		props->device_cap_flags |= IB_DEVICE_MANAGED_FLOW_STEERING;
-	}
 
 	props->device_cap_flags |= IB_DEVICE_RAW_IP_CSUM;
 
-- 
2.8.3

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH, RFC] mlx4_ib: Make steering support independent of MLX4_BMME_FLAG_TYPE_2_WIN

[Or Gerlitz]

On Thu, Jun 2, 2016 at 3:07 AM, Bart Van Assche
<bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org> wrote:
> Hello,
>
> Can anyone who is familiar with the mlx4 driver

Hi Bart,

We have set entries in the maintainers for file for both mlx4/5 core
and IB drivers, as you were asking
people to look there for srp patches... use the same practice (here
it's Yishai H.)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH, RFC] mlx4_ib: Make steering support independent of MLX4_BMME_FLAG_TYPE_2_WIN

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]

On Wed, Jun 01, 2016 at 05:07:17PM -0700, Bart Van Assche wrote:
> Hello,
> 
> Can anyone who is familiar with the mlx4 driver tell me whether or not
> the patch below makes sense? I ran into this code by analyzing the mlx4
> source code with smatch.

Hi Bart,
Thank you bringing it to our attention. I had a fast chit-chat with
Matan who was the last person who touched that area. It looks like an
unharmful issue with the code, because we had support for memory window
feature literally forever.

Thanks.

> 
> Thanks,
> 
> Bart.
> 
> ---
>  drivers/infiniband/hw/mlx4/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
> index b01ef6e..db7d0bc 100644
> --- a/drivers/infiniband/hw/mlx4/main.c
> +++ b/drivers/infiniband/hw/mlx4/main.c
> @@ -505,9 +505,9 @@ static int mlx4_ib_query_device(struct ib_device *ibdev,
>  			props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2B;
>  		else
>  			props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2A;
> +	}
>  	if (dev->steering_support ==  MLX4_STEERING_MODE_DEVICE_MANAGED)
>  		props->device_cap_flags |= IB_DEVICE_MANAGED_FLOW_STEERING;
> -	}
>  
>  	props->device_cap_flags |= IB_DEVICE_RAW_IP_CSUM;
>  
> -- 
> 2.8.3
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH, RFC] mlx4_ib: Make steering support independent of MLX4_BMME_FLAG_TYPE_2_WIN

[Sagi Grimberg]

Nice catch Bart, looks good to me,

Reviewed-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH, RFC] mlx4_ib: Make steering support independent of MLX4_BMME_FLAG_TYPE_2_WIN

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

On Thu, Jun 02, 2016 at 11:18:19AM +0300, Leon Romanovsky wrote:
> On Wed, Jun 01, 2016 at 05:07:17PM -0700, Bart Van Assche wrote:
> > Hello,
> > 
> > Can anyone who is familiar with the mlx4 driver tell me whether or not
> > the patch below makes sense? I ran into this code by analyzing the mlx4
> > source code with smatch.
> 
> Hi Bart,
> Thank you bringing it to our attention. I had a fast chit-chat with
> Matan who was the last person who touched that area. It looks like an
> unharmful issue with the code, because we had support for memory window
> feature literally forever.

hi Bart,
Do you want us to handle this fix (improve title, fill commit message)?
Or maybe you prefer to submit it by yourself?

Thanks.

> 
> Thanks.
> 
> > 
> > Thanks,
> > 
> > Bart.
> > 
> > ---
> >  drivers/infiniband/hw/mlx4/main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
> > index b01ef6e..db7d0bc 100644
> > --- a/drivers/infiniband/hw/mlx4/main.c
> > +++ b/drivers/infiniband/hw/mlx4/main.c
> > @@ -505,9 +505,9 @@ static int mlx4_ib_query_device(struct ib_device *ibdev,
> >  			props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2B;
> >  		else
> >  			props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2A;
> > +	}
> >  	if (dev->steering_support ==  MLX4_STEERING_MODE_DEVICE_MANAGED)
> >  		props->device_cap_flags |= IB_DEVICE_MANAGED_FLOW_STEERING;
> > -	}
> >  
> >  	props->device_cap_flags |= IB_DEVICE_RAW_IP_CSUM;
> >  
> > -- 
> > 2.8.3
> > 



[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]