[PATCH] IB/mlx4: Fix device managed flow steering support test

[PATCH] IB/mlx4: Fix device managed flow steering support test

[Bart Van Assche]

Perform the test for device managed flow steering support even if
memory windows are not supported. I noticed this because smatch
reported inconsistent indentation for the device managed flow
steering support test.

Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Reviewed-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
 drivers/infiniband/hw/mlx4/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
index b01ef6e..0eb09e1 100644
--- a/drivers/infiniband/hw/mlx4/main.c
+++ b/drivers/infiniband/hw/mlx4/main.c
@@ -505,9 +505,9 @@ static int mlx4_ib_query_device(struct ib_device *ibdev,
 			props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2B;
 		else
 			props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2A;
-	if (dev->steering_support ==  MLX4_STEERING_MODE_DEVICE_MANAGED)
-		props->device_cap_flags |= IB_DEVICE_MANAGED_FLOW_STEERING;
 	}
+	if (dev->steering_support == MLX4_STEERING_MODE_DEVICE_MANAGED)
+		props->device_cap_flags |= IB_DEVICE_MANAGED_FLOW_STEERING;
 
 	props->device_cap_flags |= IB_DEVICE_RAW_IP_CSUM;
 
-- 
2.8.3

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/mlx4: Fix device managed flow steering support test

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 630 bytes --]

On Fri, Jun 03, 2016 at 07:58:32AM -0700, Bart Van Assche wrote:
> Perform the test for device managed flow steering support even if
> memory windows are not supported. I noticed this because smatch
> reported inconsistent indentation for the device managed flow
> steering support test.
> 
> Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
> Reviewed-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
> Cc: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Thanks Bart,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

RE: [PATCH] IB/mlx4: Fix device managed flow steering support test

[Steve Wise]

> -----Original Message-----
> From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-
> owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Bart Van Assche
> Sent: Friday, June 03, 2016 9:59 AM
> To: Doug Ledford
> Cc: Sagi Grimberg; Yishai Hadas; leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: [PATCH] IB/mlx4: Fix device managed flow steering support test
> 
> Perform the test for device managed flow steering support even if
> memory windows are not supported. I noticed this because smatch
> reported inconsistent indentation for the device managed flow
> steering support test.
> 
> Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
> Reviewed-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
> Cc: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

Is there a commit you can reference with a Fixes line?


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/mlx4: Fix device managed flow steering support test

[Bart Van Assche]

On 06/03/2016 08:22 AM, Steve Wise wrote:
>> -----Original Message-----
>> From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-
>> owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Bart Van Assche
>> Sent: Friday, June 03, 2016 9:59 AM
>> To: Doug Ledford
>> Cc: Sagi Grimberg; Yishai Hadas; leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>> Subject: [PATCH] IB/mlx4: Fix device managed flow steering support test
>>
>> Perform the test for device managed flow steering support even if
>> memory windows are not supported. I noticed this because smatch
>> reported inconsistent indentation for the device managed flow
>> steering support test.
>>
>> Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
>> Reviewed-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
>> Cc: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>
> Is there a commit you can reference with a Fixes line?

Hello Steve,

I'm not sure it's worth to add that information. A quote from an e-mail 
that was posted yesterday on this mailing list: "It looks like an
unharmful issue with the code, because we had support for memory window
feature literally forever."

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/mlx4: Fix device managed flow steering support test

[Doug Ledford]

[-- Attachment #1.1: Type: text/plain, Size: 1423 bytes --]

On 6/3/2016 10:58 AM, Bart Van Assche wrote:
> Perform the test for device managed flow steering support even if
> memory windows are not supported. I noticed this because smatch
> reported inconsistent indentation for the device managed flow
> steering support test.
> 
> Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
> Reviewed-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
> Cc: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> ---
>  drivers/infiniband/hw/mlx4/main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mlx4/main.c b/drivers/infiniband/hw/mlx4/main.c
> index b01ef6e..0eb09e1 100644
> --- a/drivers/infiniband/hw/mlx4/main.c
> +++ b/drivers/infiniband/hw/mlx4/main.c
> @@ -505,9 +505,9 @@ static int mlx4_ib_query_device(struct ib_device *ibdev,
>  			props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2B;
>  		else
>  			props->device_cap_flags |= IB_DEVICE_MEM_WINDOW_TYPE_2A;
> -	if (dev->steering_support ==  MLX4_STEERING_MODE_DEVICE_MANAGED)
> -		props->device_cap_flags |= IB_DEVICE_MANAGED_FLOW_STEERING;
>  	}
> +	if (dev->steering_support == MLX4_STEERING_MODE_DEVICE_MANAGED)
> +		props->device_cap_flags |= IB_DEVICE_MANAGED_FLOW_STEERING;
>  
>  	props->device_cap_flags |= IB_DEVICE_RAW_IP_CSUM;
>  
> 

Thanks Bart, applied.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]