From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
Laurence Oberman
<loberman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Marciniszyn,
Mike" <mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/2] IB/srp: Always initialize use_fast_reg and use_fmr
Date: Mon, 6 Jun 2016 10:17:06 +0300 [thread overview]
Message-ID: <20160606071706.GQ7477@leon.nu> (raw)
In-Reply-To: <4b1522b5-31a2-9c7e-6b20-4e859c009345-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On Fri, Jun 03, 2016 at 11:39:35AM -0700, Bart Van Assche wrote:
> Avoid that mapping fails due to use_fast_reg != 0 or use_fmr != 0
> if both member variables should be zero (if never_register == 1 or
> if neither FMR nor FR is supported). Remove an initialization that
> became superfluous due to changing a kmalloc() into a kzalloc()
> call.
>
> Fixes: 509c5f33f4f6 ("IB/srp: Prevent mapping failures")
> Cc: Sagi Grimberg <sai@grimberg.m>
> Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
> Cc: Laurence Oberman <loberman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-06 7:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 18:38 [PATCH 0/2] SRP initiator fixes for kernel v4.7 Bart Van Assche
[not found] ` <4b4cc34a-eebb-8534-3d76-1cfb3fe961f5-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-06-03 18:39 ` [PATCH 1/2] IB/srp: Always initialize use_fast_reg and use_fmr Bart Van Assche
[not found] ` <4b1522b5-31a2-9c7e-6b20-4e859c009345-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-06-06 7:17 ` Leon Romanovsky [this message]
2016-06-06 11:08 ` Sagi Grimberg
2016-06-06 17:33 ` Christoph Hellwig
2016-06-03 18:40 ` [PATCH 2/2] IB/srp: Fix srp_map_sg_dma() Bart Van Assche
[not found] ` <25293485-8307-5361-c6fc-6bcadd832249-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-06-06 11:09 ` Sagi Grimberg
2016-06-06 17:33 ` Christoph Hellwig
2016-06-03 18:58 ` [PATCH 0/2] SRP initiator fixes for kernel v4.7 Laurence Oberman
[not found] ` <178183518.40193929.1464980291652.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-03 23:43 ` Laurence Oberman
2016-06-06 23:33 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606071706.GQ7477@leon.nu \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=loberman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox