From: Greg KH <greg@kroah.com>
To: hch <hch@infradead.org>
Cc: Leon Romanovsky <leon@leon.nu>, Sagi Grimberg <sagi@grimberg.me>,
stable@vger.kernel.org, linux-rdma@vger.kernel.org,
Max Gurtovoy <maxg@mellanox.com>,
matanb@mellanox.com, robert@leblancnet.us
Subject: Re: [PATCH v3 2/2] IB/core: Align casting method of ib_device_cap_flags enumerations to ULL
Date: Mon, 6 Jun 2016 10:40:11 -0700 [thread overview]
Message-ID: <20160606174011.GB24836@kroah.com> (raw)
In-Reply-To: <20160606172246.GB21118@infradead.org>
On Mon, Jun 06, 2016 at 10:22:46AM -0700, hch wrote:
> > Later on, we will wrap all these shifts in BIT() macros as Greg suggested.
>
> Big NAK to any use of that macro.
That's odd, given that most of the kernel has already converted to use
it. You can try to keep it out of this subsystem, but you will get
patches to convert it from random people and it will wear you down over
time...
sorry,
greg k-h
next prev parent reply other threads:[~2016-06-06 17:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 16:34 [PATCH v3 0/2] fix ib_device_cap_flags bit curruption Max Gurtovoy
2016-06-06 16:34 ` [PATCH v3 1/2] IB/core: Fix bit curruption in ib_device_cap_flags structure Max Gurtovoy
[not found] ` <1465230880-25953-2-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-06-06 17:03 ` Christoph Hellwig
[not found] ` <1465230880-25953-1-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-06-06 16:34 ` [PATCH v3 2/2] IB/core: Align casting method of ib_device_cap_flags enumerations to ULL Max Gurtovoy
2016-06-06 17:04 ` Christoph Hellwig
[not found] ` <20160606170413.GB28622-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2016-06-06 17:15 ` Greg KH
[not found] ` <20160606171543.GA14882-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-06-06 17:22 ` Christoph Hellwig
2016-06-06 18:31 ` Max Gurtovoy
[not found] ` <CALq1K=JWPk6nPjTV0z1HwfmtnO77Nkyaqx-JTB=8JwH0UtorDA@mail.gmail.com>
[not found] ` <CALq1K=JWPk6nPjTV0z1HwfmtnO77Nkyaqx-JTB=8JwH0UtorDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-06 17:22 ` hch
2016-06-06 17:40 ` Greg KH [this message]
[not found] ` <20160606174011.GB24836-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2016-06-06 17:45 ` Bart Van Assche
2016-06-07 12:00 ` [PATCH v3 0/2] fix ib_device_cap_flags bit curruption Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606174011.GB24836@kroah.com \
--to=greg@kroah.com \
--cc=hch@infradead.org \
--cc=leon@leon.nu \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=maxg@mellanox.com \
--cc=robert@leblancnet.us \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox