From: Tejun Heo <tj@kernel.org>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] IB/srp: Remove create_workqueue
Date: Tue, 7 Jun 2016 14:21:06 -0500 [thread overview]
Message-ID: <20160607192106.GY31708@htj.duckdns.org> (raw)
In-Reply-To: <f3d26daf-1805-7046-f45b-b8965156d83f@sandisk.com>
On Tue, Jun 07, 2016 at 11:32:42AM -0700, Bart Van Assche wrote:
> On 06/07/2016 11:16 AM, Bhaktipriya Shridhar wrote:
> > alloc_workqueue replaces deprecated create_workqueue().
> >
> > A dedicated workqueue has been used since the workqueue srp_remove_wq with
> > workitem &target->remove_work, is a work queue for the SRP target removal.
> > WQ_MEM_RECLAIM has been set to ensure forward progress under memory
> > pressure.
> > Since there are only a fixed number of work items, explicit
> > concurrency limit is unnecessary here.
> >
> > Is the workqueue being used on a memory reclaim path?
> > Does it require WQ_MEM_RECLAIM?
>
> Hello Bhaktipriya,
>
> srp_remove_wq is used for SRP target port removal work only. This work is
> neither queued from inside a shrinker nor by the page writeback code so I
> think it is safe to drop WQ_MEM_RECLAIM.
It should be able to use system_wq then.
Thanks for the explanation!
--
tejun
next prev parent reply other threads:[~2016-06-07 19:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 18:16 [RFC] IB/srp: Remove create_workqueue Bhaktipriya Shridhar
2016-06-07 18:32 ` Bart Van Assche
2016-06-07 19:21 ` Tejun Heo [this message]
2016-06-07 19:56 ` Bart Van Assche
2016-06-07 20:00 ` Bart Van Assche
[not found] ` <dcee0161-3210-0cfb-c0e6-bba7259ad639-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-06-20 18:59 ` Tejun Heo
[not found] ` <20160620185922.GQ3262-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2016-06-21 8:14 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607192106.GY31708@htj.duckdns.org \
--to=tj@kernel.org \
--cc=bart.vanassche@sandisk.com \
--cc=bhaktipriya96@gmail.com \
--cc=dledford@redhat.com \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox