From: Dennis Dalessandro <dennis.dalessandro-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jubin John <jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Dean Luick <dean.luick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: [PATCH 04/10] IB/hfi1: Increase packet egress timeout
Date: Thu, 09 Jun 2016 07:51:27 -0700 [thread overview]
Message-ID: <20160609145125.12702.47309.stgit@scvm10.sc.intel.com> (raw)
In-Reply-To: <20160609144644.12702.4832.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
From: Jubin John <jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
The current value of 500us for the packet egress timeout is too small
which causes the host to declare failure on draining packets too early
and unnecessarily bounces the link. Increase this to 50ms taking into
account the switch packet discard timer default and the worst case
per-VL package drainage rate.
Reviewed-by: Dean Luick <dean.luick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Jubin John <jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
drivers/infiniband/hw/hfi1/pio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/hfi1/pio.c b/drivers/infiniband/hw/hfi1/pio.c
index e0e1ff2..d402245 100644
--- a/drivers/infiniband/hw/hfi1/pio.c
+++ b/drivers/infiniband/hw/hfi1/pio.c
@@ -995,7 +995,7 @@ static void sc_wait_for_packet_egress(struct send_context *sc, int pause)
/* counter is reset if occupancy count changes */
if (reg != reg_prev)
loop = 0;
- if (loop > 500) {
+ if (loop > 50000) {
/* timed out - bounce the link */
dd_dev_err(dd,
"%s: context %u(%u) timeout waiting for packets to egress, remaining count %u, bouncing link\n",
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-09 14:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 14:51 [PATCH 00/10] IB/hfi1,qib,rdmavt: Fixes for 4.7 rc Dennis Dalessandro
[not found] ` <20160609144644.12702.4832.stgit-9QXIwq+3FY+1XWohqUldA0EOCMrvLtNR@public.gmane.org>
2016-06-09 14:51 ` [PATCH 01/10] IB/hfi1: Fix credit return threshold adjustment Dennis Dalessandro
2016-06-09 14:51 ` [PATCH 02/10] IB/rdmavt: Correct required callback functions for MODIFY_QP Dennis Dalessandro
2016-06-09 14:51 ` [PATCH 03/10] IB/rdmavt: Correct warning during QPN allocation Dennis Dalessandro
2016-06-09 14:51 ` Dennis Dalessandro [this message]
2016-06-09 14:51 ` [PATCH 05/10] IB/hfi1: Prevent context loss Dennis Dalessandro
2016-06-09 14:51 ` [PATCH 06/10] IB/qib: " Dennis Dalessandro
2016-06-09 14:51 ` [PATCH 07/10] IB/hfi1: Fix potential NULL ptr dereference Dennis Dalessandro
2016-06-09 14:51 ` [PATCH 08/10] IB/hfi1: Fix potential buffer overflow Dennis Dalessandro
2016-06-09 14:51 ` [PATCH 09/10] IB/hfi1: Remove FULL_MGMT_P_KEY from pkey table at link up Dennis Dalessandro
2016-06-09 14:52 ` [PATCH 10/10] IB/hfi1: Send a pkey change event on driver pkey update Dennis Dalessandro
2016-06-18 0:11 ` [PATCH 00/10] IB/hfi1,qib,rdmavt: Fixes for 4.7 rc Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609145125.12702.47309.stgit@scvm10.sc.intel.com \
--to=dennis.dalessandro-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=dean.luick-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=jubin.john-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox