Re: [PATCH rdma-next 00/29] Soft RoCE driver

Dennis Dalessandro
2016-06-09T19:47:59Z

On Thu, Jun 09, 2016 at 10:16:08PM +0300, Leon Romanovsky wrote:
>On Thu, Jun 09, 2016 at 10:45:55AM -0400, Dennis Dalessandro wrote:
>> On Thu, Jun 09, 2016 at 04:17:15PM +0300, Moni Shoua wrote:
>> >2. Trying to force SoftRoCE on this model will end up with rxe driver
>> >registers to rvt with all ib_device hooks implemented. This makes the
>> >reason to use rvt irrelevant in this case.
>>
>> Everything? What about AH, MR, PD? Aren't those pretty generic constructs.
>> In fact you folks submitted the change for AH.
>>
>
>Despite the fact that I submitted change to hfi1, it doesn't make me
>stake holder of that driver.

Let me be more clear. My point is that AH was generic enough for someone at
Mellanox who was working on soft roce to write a patch for in the first
place. Now it's somehow not generic enough and would need it's own driver
specific hook?

Is just being able to use rdmavt's AH functionality enough to justify using
it? Probably not, but I see MR, PD, even CQ as being totally generic, is
that enough? Maybe, maybe not. QP, I think may have some difficulties, maybe
that's the deal breaker? Bottom line is you can't say _all_ rdmavt functions
would need overridden.

So perhaps a statement as to what high level blocks of rdmavt could not be
used would help put the matter to rest?

-Denny