Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

Leon Romanovsky
2016-06-23T07:12:10Z

[-- Attachment #1: Type: text/plain, Size: 2134 bytes --]

On Thu, Jun 23, 2016 at 08:27:01AM +0300, Leon Romanovsky wrote:
> On Wed, Jun 22, 2016 at 11:23:59AM -0700, Joe Perches wrote:
> > The logging macros create a bit of duplicated code/text.
> >
> > Use specialized functions to reduce the duplication.
> >
> > (defconfig/x86-64)
> > $ size drivers/net/ethernet/mellanox/mlx5/core/built-in.o*
> >    text    data     bss     dec     hex filename
> >  178634    2059      16  180709   2c1e5 drivers/net/ethernet/mellanox/mlx5/core/built-in.o.new
> >  188679    2059      16  190754   2e922 drivers/net/ethernet/mellanox/mlx5/core/built-in.o.old
> >
> > The output changes now do not include line #,
> > but do include the function offset.
> >
> > Signed-off-by: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
>
> As far as I see all these functions are used in error paths, so no
> implication on performance is expected.
>
> And I'm fine with function offsets.
>
> Saeed,
> What do you think?
>
> Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

I continued to play with this patch and it doesn't pass checkpatch.
It looks like corrupted file.

➜ linux-rdma git:(master) ./scripts/checkpatch.pl
~/Downloads/mellanox-mlx5-Use-logging-functions-to-reduce-text-10k-5.patch
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#21:
178634    2059      16  180709   2c1e5
drivers/net/ethernet/mellanox/mlx5/core/built-in.o.new

ERROR: patch seems to be corrupt (line wrapped?)
#46: FILE: drivers/net/ethernet/mellanox/mlx5/core/main.c:1556:

CHECK: Alignment should match open parenthesis
#78: FILE: drivers/net/ethernet/mellanox/mlx5/core/main.c:1586:
+ dev_warn(&dev->pdev->dev, "%s:%pS:(pid %d): %pV",
+  dev->priv.name, __builtin_return_address(0), current->pid,

ERROR: space required before that '&' (ctx:VxV)
#79: FILE: drivers/net/ethernet/mellanox/mlx5/core/main.c:1587:
+  &vaf);
^
total: 2 errors, 1 warnings, 1 checks, 58 lines checked

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]