From: Leon Romanovsky <leon@kernel.org>
To: oulijun <oulijun@huawei.com>
Cc: Doug Ledford <dledford@redhat.com>,
sean.hefty@intel.com, hal.rosenstock@gmail.com,
davem@davemloft.net, jeffrey.t.kirsher@intel.com,
jiri@mellanox.com, ogerlitz@mellanox.com,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, gongyangming@huawei.com,
xiaokun@huawei.com, tangchaofei@huawei.com,
haifeng.wei@huawei.com, yisen.zhuang@huawei.com,
yankejian@huawei.com, charles.chenxin@huawei.com,
linuxarm@huawei.com
Subject: Re: [PATCH v10 07/22] IB/hns: Add event queue support
Date: Wed, 29 Jun 2016 13:41:32 +0300 [thread overview]
Message-ID: <20160629104132.GA4750@leon.nu> (raw)
In-Reply-To: <57738C93.8010900@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 564 bytes --]
On Wed, Jun 29, 2016 at 04:53:39PM +0800, oulijun wrote:
> >> +
> >> + for (i = 0; i < npages; ++i)
> >> + if (eq->buf_list[i].buf)
> >
> > Is it possible situation to have eq->buf_list[i].buf == NULL at the
> > middle of iteration?
> >
> We have analysized it according to your reivews. We think that the eq->buf_list[i].buf
> is not NULL at the middle of iteration because only the eq->buf_list[i].buf allocated
> when the hns_roce_free_eq be called. As result, the if (eq->buf_list[i].buf) condition
> should be deleted, right?
Yes, please.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-29 10:41 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-16 14:35 [PATCH v10 00/22] Add HiSilicon RoCE driver Lijun Ou
2016-06-16 14:35 ` [PATCH v10 01/22] net: hns: Add reset function support for " Lijun Ou
2016-06-24 11:49 ` Leon Romanovsky
2016-06-27 6:41 ` oulijun
2016-06-16 14:35 ` [PATCH v10 02/22] devicetree: bindings: IB: Add binding document for HiSilicon RoCE Lijun Ou
2016-06-16 14:35 ` [PATCH v10 04/22] IB/hns: Add RoCE engine reset function Lijun Ou
[not found] ` <1466087730-54856-5-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-24 14:59 ` Leon Romanovsky
[not found] ` <576E5C21.5030904@huawei.com>
2016-06-27 8:01 ` Leon Romanovsky
[not found] ` <20160627080122.GA3584-2ukJVAZIZ/Y@public.gmane.org>
2016-06-27 8:31 ` oulijun
[not found] ` <5770E465.1070702-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-28 6:31 ` Wei Hu (Xavier)
[not found] ` <577219CD.2000604-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-28 8:09 ` Leon Romanovsky
2016-06-16 14:35 ` [PATCH v10 05/22] IB/hns: Add initial profile resource Lijun Ou
[not found] ` <1466087730-54856-6-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-24 15:10 ` Leon Romanovsky
[not found] ` <20160624151048.GF23995-2ukJVAZIZ/Y@public.gmane.org>
2016-06-28 6:56 ` oulijun
[not found] ` <1466087730-54856-1-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-16 14:35 ` [PATCH v10 03/22] IB/hns: Add initial main frame driver and get cfg info Lijun Ou
[not found] ` <1466087730-54856-4-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-24 11:48 ` Leon Romanovsky
[not found] ` <576E5D0B.7010003@huawei.com>
[not found] ` <576E5D0B.7010003-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-27 7:00 ` Leon Romanovsky
[not found] ` <20160627070054.GK23995-2ukJVAZIZ/Y@public.gmane.org>
2016-06-27 7:29 ` Wei Hu (Xavier)
2016-06-16 14:35 ` [PATCH v10 06/22] IB/hns: Add initial cmd operation Lijun Ou
[not found] ` <1466087730-54856-7-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-20 13:33 ` Leon Romanovsky
2016-06-21 10:50 ` Wei Hu (Xavier)
2016-06-21 11:28 ` Leon Romanovsky
2016-06-21 13:01 ` Wei Hu (Xavier)
2016-06-22 4:54 ` Leon Romanovsky
2016-06-22 6:50 ` Wei Hu (Xavier)
[not found] ` <576A352F.8000700-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-22 7:28 ` Leon Romanovsky
[not found] ` <20160622072845.GE9762-2ukJVAZIZ/Y@public.gmane.org>
2016-06-22 7:33 ` Wei Hu (Xavier)
[not found] ` <576A3F49.6040305-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-22 7:41 ` Leon Romanovsky
[not found] ` <20160622074108.GF9762-2ukJVAZIZ/Y@public.gmane.org>
2016-06-22 7:48 ` Wei Hu (Xavier)
2016-06-16 14:35 ` [PATCH v10 12/22] IB/hns: Set mtu and gid support Lijun Ou
2016-06-16 14:35 ` [PATCH v10 14/22] IB/hns: Add operations support for IB device and port Lijun Ou
2016-06-16 14:35 ` [PATCH v10 22/22] MAINTAINERS: Add maintainers for HiSilicon RoCE driver Lijun Ou
2016-06-24 15:55 ` [PATCH v10 00/22] Add " Leon Romanovsky
2016-06-16 14:35 ` [PATCH v10 07/22] IB/hns: Add event queue support Lijun Ou
2016-06-24 15:46 ` Leon Romanovsky
[not found] ` <20160624154643.GG23995-2ukJVAZIZ/Y@public.gmane.org>
2016-06-24 15:56 ` Doug Ledford
2016-06-29 8:53 ` oulijun
2016-06-29 10:41 ` Leon Romanovsky [this message]
2016-06-16 14:35 ` [PATCH v10 08/22] IB/hns: Add icm support Lijun Ou
2016-06-17 9:58 ` Leon Romanovsky
[not found] ` <57677314.70909@huawei.com>
[not found] ` <57677314.70909-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-20 6:06 ` Leon Romanovsky
[not found] ` <20160620060614.GC1172-2ukJVAZIZ/Y@public.gmane.org>
2016-06-20 7:49 ` Wei Hu (Xavier)
2016-06-20 9:27 ` Leon Romanovsky
[not found] ` <20160620092719.GE1172-2ukJVAZIZ/Y@public.gmane.org>
2016-06-20 9:48 ` Wei Hu (Xavier)
[not found] ` <5767BBDF.6010309-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-20 13:04 ` Leon Romanovsky
[not found] ` <20160620130422.GA4526-2ukJVAZIZ/Y@public.gmane.org>
2016-06-21 4:37 ` Wei Hu (Xavier)
[not found] ` <5768C493.6000300-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-21 11:55 ` Leon Romanovsky
2016-06-22 3:53 ` Wei Hu (Xavier)
[not found] ` <576A0BAD.1070803-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-22 5:27 ` Leon Romanovsky
2016-06-16 14:35 ` [PATCH v10 09/22] IB/hns: Add hca support Lijun Ou
[not found] ` <1466087730-54856-10-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-06-24 15:50 ` Leon Romanovsky
2016-06-16 14:35 ` [PATCH v10 10/22] IB/hns: Add process flow to init RoCE engine Lijun Ou
2016-06-16 14:35 ` [PATCH v10 11/22] IB/hns: Add IB device registration Lijun Ou
2016-06-16 14:35 ` [PATCH v10 13/22] IB/hns: Add interface of the protocol stack registration Lijun Ou
2016-06-16 14:35 ` [PATCH v10 15/22] IB/hns: Add PD operations support Lijun Ou
2016-06-16 14:35 ` [PATCH v10 16/22] IB/hns: Add ah " Lijun Ou
2016-06-16 14:35 ` [PATCH v10 17/22] IB/hns: Add QP " Lijun Ou
2016-06-16 14:35 ` [PATCH v10 18/22] IB/hns: Add CQ " Lijun Ou
2016-06-16 14:35 ` [PATCH v10 19/22] IB/hns: Add memory region " Lijun Ou
2016-06-16 14:35 ` [PATCH v10 20/22] IB/hns: Add operation for getting immutable port Lijun Ou
2016-06-16 14:35 ` [PATCH v10 21/22] IB/hns: Kconfig and Makefile for RoCE module Lijun Ou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629104132.GA4750@leon.nu \
--to=leon@kernel.org \
--cc=charles.chenxin@huawei.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=gongyangming@huawei.com \
--cc=haifeng.wei@huawei.com \
--cc=hal.rosenstock@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=oulijun@huawei.com \
--cc=sean.hefty@intel.com \
--cc=tangchaofei@huawei.com \
--cc=xiaokun@huawei.com \
--cc=yankejian@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox