From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [RFC ABI V1 1/8] RDMA/core: Export RDMA IOCTL declarations Date: Tue, 12 Jul 2016 13:12:56 -0600 Message-ID: <20160712191256.GA8206@obsidianresearch.com> References: <1467293971-25688-1-git-send-email-matanb@mellanox.com> <1467293971-25688-2-git-send-email-matanb@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1467293971-25688-2-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matan Barak Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Ledford , Sean Hefty , Tal Alon , Liran Liss , Haggai Eran , Majd Dibbiny , Christoph Lameter , Leon Romanovsky List-Id: linux-rdma@vger.kernel.org On Thu, Jun 30, 2016 at 04:39:24PM +0300, Matan Barak wrote: > From: Leon Romanovsky > > Place all external RDMA IOCTL declarations into one UAPI exported > header file and move all legacy MAD commands to that file. > > Signed-off-by: Matan Barak > Signed-off-by: Haggai Eran > Signed-off-by: Leon Romanovsky This patch seems fine to me. > +/* Legacy part > + * !!!! NOTE: It uses the same command index as VERBS Not sure what this comment means, all IOCTLs in this file should use IB_IOCTL_MAGIC .. > +#include Strange not to be at the top. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html