From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [RFC ABI V1 2/8] RDMA/core: Move uobject code to separate files Date: Tue, 12 Jul 2016 13:15:07 -0600 Message-ID: <20160712191507.GB8206@obsidianresearch.com> References: <1467293971-25688-1-git-send-email-matanb@mellanox.com> <1467293971-25688-3-git-send-email-matanb@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1467293971-25688-3-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matan Barak Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Ledford , Sean Hefty , Tal Alon , Liran Liss , Haggai Eran , Majd Dibbiny , Christoph Lameter , Leon Romanovsky List-Id: linux-rdma@vger.kernel.org On Thu, Jun 30, 2016 at 04:39:25PM +0300, Matan Barak wrote: > From: Leon Romanovsky > > The new proposed infrastructure allows driver's to declare new object > types. Furthermore, uobject management code will be used from both > the old legacy code and the new ioctl infrastructure. Seems reasonable. > +static inline void put_pd_read(struct ib_pd *pd) > +{ > + put_uobj_read(pd->uobject); > +} Ultimately I think we should get rid of these sorts of wrappers and just open code it - especailly as we are talking about growing the number of uboject types. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html