Re: [RFC ABI V1 1/8] RDMA/core: Export RDMA IOCTL declarations

[Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]

On Tue, Jul 12, 2016 at 01:12:56PM -0600, Jason Gunthorpe wrote:
> On Thu, Jun 30, 2016 at 04:39:24PM +0300, Matan Barak wrote:
> > From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > 
> > Place all external RDMA IOCTL declarations into one UAPI exported
> > header file and move all legacy MAD commands to that file.
> > 
> > Signed-off-by: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > Signed-off-by: Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> 
> This patch seems fine to me.
> 
> > +/* Legacy part
> > + * !!!! NOTE: It uses the same command index as VERBS
> 
> Not sure what this comment means, all IOCTLs in this file should use
> IB_IOCTL_MAGIC  ..

I meant numbers 1,2,... in the defines, wrote as a reminder.
+#define IB_USER_MAD_REGISTER_AGENT     _IOWR(IB_IOCTL_MAGIC, 1, \
------------------------------------------------------------^^^^^---

> 
> > +#include <rdma/ib_user_mad.h>
> 
> Strange not to be at the top.

To be on safe side, to preserve legacy structure.

> 
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]