IB/mlx4: Use EAGAIN error code instead or EINVAL in function mlx4_ib_poll_one

IB/mlx4: Use EAGAIN error code instead or EINVAL in function mlx4_ib_poll_one

[Yuval Shaia]

Please review the following two patches.
First patch makes int-return function to a void one as it anyway returns 0.
Second patch replace all EINVAL error codes returned from mlx4_ib_poll_one
to EAGAIN.

[PATCH 1/2] IB/mlx4: Make function use_tunnel_data return void
[PATCH 2/2] IB/mlx4: Return EAGAIN for any error in mlx4_ib_poll_one
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] IB/mlx4: Make function use_tunnel_data return void

[Yuval Shaia]

No need to return int if function always returns 0

Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
 drivers/infiniband/hw/mlx4/cq.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/infiniband/hw/mlx4/cq.c b/drivers/infiniband/hw/mlx4/cq.c
index 9f8b516..4c2e1b0 100644
--- a/drivers/infiniband/hw/mlx4/cq.c
+++ b/drivers/infiniband/hw/mlx4/cq.c
@@ -576,8 +576,8 @@ static int mlx4_ib_ipoib_csum_ok(__be16 status, __be16 checksum)
 		checksum == cpu_to_be16(0xffff);
 }
 
-static int use_tunnel_data(struct mlx4_ib_qp *qp, struct mlx4_ib_cq *cq, struct ib_wc *wc,
-			   unsigned tail, struct mlx4_cqe *cqe, int is_eth)
+static void use_tunnel_data(struct mlx4_ib_qp *qp, struct mlx4_ib_cq *cq, struct ib_wc *wc,
+			    unsigned tail, struct mlx4_cqe *cqe, int is_eth)
 {
 	struct mlx4_ib_proxy_sqp_hdr *hdr;
 
@@ -600,8 +600,6 @@ static int use_tunnel_data(struct mlx4_ib_qp *qp, struct mlx4_ib_cq *cq, struct
 		wc->slid        = be16_to_cpu(hdr->tun.slid_mac_47_32);
 		wc->sl          = (u8) (be16_to_cpu(hdr->tun.sl_vid) >> 12);
 	}
-
-	return 0;
 }
 
 static void mlx4_ib_qp_sw_comp(struct mlx4_ib_qp *qp, int num_entries,
@@ -853,8 +851,9 @@ repoll:
 			if ((*cur_qp)->mlx4_ib_qp_type &
 			    (MLX4_IB_QPT_PROXY_SMI_OWNER |
 			     MLX4_IB_QPT_PROXY_SMI | MLX4_IB_QPT_PROXY_GSI))
-				return use_tunnel_data(*cur_qp, cq, wc, tail,
-						       cqe, is_eth);
+				use_tunnel_data(*cur_qp, cq, wc, tail, cqe,
+						is_eth);
+				return 0;
 		}
 
 		wc->slid	   = be16_to_cpu(cqe->rlid);
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] IB/mlx4: Make function use_tunnel_data return void

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 3339 bytes --]

Hi,

[auto build test WARNING on rdma/master]
[also build test WARNING on v4.7 next-20160726]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Yuval-Shaia/IB-mlx4-Make-function-use_tunnel_data-return-void/20160727-162724
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git master
config: x86_64-randconfig-x014-201630 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/infiniband/hw/mlx4/cq.c: In function 'mlx4_ib_poll_one':
>> drivers/infiniband/hw/mlx4/cq.c:851:4: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
       if ((*cur_qp)->mlx4_ib_qp_type &
       ^~
   drivers/infiniband/hw/mlx4/cq.c:856:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
        return 0;
        ^~~~~~

vim +/if +851 drivers/infiniband/hw/mlx4/cq.c

95d04f07 Roland Dreier    2008-07-23  835  			break;
225c7b1f Roland Dreier    2007-05-08  836  		case MLX4_RECV_OPCODE_SEND:
225c7b1f Roland Dreier    2007-05-08  837  			wc->opcode   = IB_WC_RECV;
225c7b1f Roland Dreier    2007-05-08  838  			wc->wc_flags = 0;
225c7b1f Roland Dreier    2007-05-08  839  			break;
225c7b1f Roland Dreier    2007-05-08  840  		case MLX4_RECV_OPCODE_SEND_IMM:
225c7b1f Roland Dreier    2007-05-08  841  			wc->opcode	= IB_WC_RECV;
225c7b1f Roland Dreier    2007-05-08  842  			wc->wc_flags	= IB_WC_WITH_IMM;
00f7ec36 Steve Wise       2008-07-14  843  			wc->ex.imm_data = cqe->immed_rss_invalid;
225c7b1f Roland Dreier    2007-05-08  844  			break;
225c7b1f Roland Dreier    2007-05-08  845  		}
225c7b1f Roland Dreier    2007-05-08  846  
5ea8bbfc Jack Morgenstein 2014-03-12  847  		is_eth = (rdma_port_get_link_layer(wc->qp->device,
5ea8bbfc Jack Morgenstein 2014-03-12  848  						  (*cur_qp)->port) ==
5ea8bbfc Jack Morgenstein 2014-03-12  849  			  IB_LINK_LAYER_ETHERNET);
1ffeb2eb Jack Morgenstein 2012-08-03  850  		if (mlx4_is_mfunc(to_mdev(cq->ibcq.device)->dev)) {
1ffeb2eb Jack Morgenstein 2012-08-03 @851  			if ((*cur_qp)->mlx4_ib_qp_type &
1ffeb2eb Jack Morgenstein 2012-08-03  852  			    (MLX4_IB_QPT_PROXY_SMI_OWNER |
1ffeb2eb Jack Morgenstein 2012-08-03  853  			     MLX4_IB_QPT_PROXY_SMI | MLX4_IB_QPT_PROXY_GSI))
3404b0d4 Yuval Shaia      2016-07-27  854  				use_tunnel_data(*cur_qp, cq, wc, tail, cqe,
3404b0d4 Yuval Shaia      2016-07-27  855  						is_eth);
3404b0d4 Yuval Shaia      2016-07-27  856  				return 0;
1ffeb2eb Jack Morgenstein 2012-08-03  857  		}
1ffeb2eb Jack Morgenstein 2012-08-03  858  
225c7b1f Roland Dreier    2007-05-08  859  		wc->slid	   = be16_to_cpu(cqe->rlid);

:::::: The code at line 851 was first introduced by commit
:::::: 1ffeb2eb8be9936e9dc1f9af2d5f4c14d69a0d36 IB/mlx4: SR-IOV IB context objects and proxy/tunnel SQP support

:::::: TO: Jack Morgenstein <jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
:::::: CC: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 33827 bytes --]

Re: [PATCH 1/2] IB/mlx4: Make function use_tunnel_data return void

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 2121 bytes --]

On Wed, Jul 27, 2016 at 01:24:52AM -0700, Yuval Shaia wrote:
> No need to return int if function always returns 0
> 
> Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
>  drivers/infiniband/hw/mlx4/cq.c |   11 +++++------
>  1 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/mlx4/cq.c b/drivers/infiniband/hw/mlx4/cq.c
> index 9f8b516..4c2e1b0 100644
> --- a/drivers/infiniband/hw/mlx4/cq.c
> +++ b/drivers/infiniband/hw/mlx4/cq.c
> @@ -576,8 +576,8 @@ static int mlx4_ib_ipoib_csum_ok(__be16 status, __be16 checksum)
>  		checksum == cpu_to_be16(0xffff);
>  }
>  
> -static int use_tunnel_data(struct mlx4_ib_qp *qp, struct mlx4_ib_cq *cq, struct ib_wc *wc,
> -			   unsigned tail, struct mlx4_cqe *cqe, int is_eth)
> +static void use_tunnel_data(struct mlx4_ib_qp *qp, struct mlx4_ib_cq *cq, struct ib_wc *wc,
> +			    unsigned tail, struct mlx4_cqe *cqe, int is_eth)
>  {
>  	struct mlx4_ib_proxy_sqp_hdr *hdr;
>  
> @@ -600,8 +600,6 @@ static int use_tunnel_data(struct mlx4_ib_qp *qp, struct mlx4_ib_cq *cq, struct
>  		wc->slid        = be16_to_cpu(hdr->tun.slid_mac_47_32);
>  		wc->sl          = (u8) (be16_to_cpu(hdr->tun.sl_vid) >> 12);
>  	}
> -
> -	return 0;
>  }
>  
>  static void mlx4_ib_qp_sw_comp(struct mlx4_ib_qp *qp, int num_entries,
> @@ -853,8 +851,9 @@ repoll:
>  			if ((*cur_qp)->mlx4_ib_qp_type &
>  			    (MLX4_IB_QPT_PROXY_SMI_OWNER |
>  			     MLX4_IB_QPT_PROXY_SMI | MLX4_IB_QPT_PROXY_GSI))
> -				return use_tunnel_data(*cur_qp, cq, wc, tail,
> -						       cqe, is_eth);
> +				use_tunnel_data(*cur_qp, cq, wc, tail, cqe,
> +						is_eth);
> +				return 0;

Yeah, kbuild spotted excellent point.
It should be guarded by {}

return X -> { X; return 0; }

>  		}
>  
>  		wc->slid	   = be16_to_cpu(cqe->rlid);
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH 1/2] IB/mlx4: Make function use_tunnel_data return void

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 4039 bytes --]

Hi,

[auto build test WARNING on rdma/master]
[also build test WARNING on v4.7 next-20160727]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Yuval-Shaia/IB-mlx4-Make-function-use_tunnel_data-return-void/20160727-162724
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git master
config: x86_64-randconfig-n0-07271932 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/mlx4/cq.h:36,
                    from drivers/infiniband/hw/mlx4/cq.c:34:
   drivers/infiniband/hw/mlx4/cq.c: In function 'mlx4_ib_poll_one':
   include/linux/compiler.h:151:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
     ^
   include/linux/compiler.h:149:23: note: in expansion of macro '__trace_if'
    #define if(cond, ...) __trace_if( (cond , ## __VA_ARGS__) )
                          ^~~~~~~~~~
>> drivers/infiniband/hw/mlx4/cq.c:851:4: note: in expansion of macro 'if'
       if ((*cur_qp)->mlx4_ib_qp_type &
       ^~
   drivers/infiniband/hw/mlx4/cq.c:856:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
        return 0;
        ^~~~~~

vim +/if +851 drivers/infiniband/hw/mlx4/cq.c

95d04f07 Roland Dreier    2008-07-23  835  			break;
225c7b1f Roland Dreier    2007-05-08  836  		case MLX4_RECV_OPCODE_SEND:
225c7b1f Roland Dreier    2007-05-08  837  			wc->opcode   = IB_WC_RECV;
225c7b1f Roland Dreier    2007-05-08  838  			wc->wc_flags = 0;
225c7b1f Roland Dreier    2007-05-08  839  			break;
225c7b1f Roland Dreier    2007-05-08  840  		case MLX4_RECV_OPCODE_SEND_IMM:
225c7b1f Roland Dreier    2007-05-08  841  			wc->opcode	= IB_WC_RECV;
225c7b1f Roland Dreier    2007-05-08  842  			wc->wc_flags	= IB_WC_WITH_IMM;
00f7ec36 Steve Wise       2008-07-14  843  			wc->ex.imm_data = cqe->immed_rss_invalid;
225c7b1f Roland Dreier    2007-05-08  844  			break;
225c7b1f Roland Dreier    2007-05-08  845  		}
225c7b1f Roland Dreier    2007-05-08  846  
5ea8bbfc Jack Morgenstein 2014-03-12  847  		is_eth = (rdma_port_get_link_layer(wc->qp->device,
5ea8bbfc Jack Morgenstein 2014-03-12  848  						  (*cur_qp)->port) ==
5ea8bbfc Jack Morgenstein 2014-03-12  849  			  IB_LINK_LAYER_ETHERNET);
1ffeb2eb Jack Morgenstein 2012-08-03  850  		if (mlx4_is_mfunc(to_mdev(cq->ibcq.device)->dev)) {
1ffeb2eb Jack Morgenstein 2012-08-03 @851  			if ((*cur_qp)->mlx4_ib_qp_type &
1ffeb2eb Jack Morgenstein 2012-08-03  852  			    (MLX4_IB_QPT_PROXY_SMI_OWNER |
1ffeb2eb Jack Morgenstein 2012-08-03  853  			     MLX4_IB_QPT_PROXY_SMI | MLX4_IB_QPT_PROXY_GSI))
3404b0d4 Yuval Shaia      2016-07-27  854  				use_tunnel_data(*cur_qp, cq, wc, tail, cqe,
3404b0d4 Yuval Shaia      2016-07-27  855  						is_eth);
3404b0d4 Yuval Shaia      2016-07-27  856  				return 0;
1ffeb2eb Jack Morgenstein 2012-08-03  857  		}
1ffeb2eb Jack Morgenstein 2012-08-03  858  
225c7b1f Roland Dreier    2007-05-08  859  		wc->slid	   = be16_to_cpu(cqe->rlid);

:::::: The code at line 851 was first introduced by commit
:::::: 1ffeb2eb8be9936e9dc1f9af2d5f4c14d69a0d36 IB/mlx4: SR-IOV IB context objects and proxy/tunnel SQP support

:::::: TO: Jack Morgenstein <jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
:::::: CC: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 30883 bytes --]

[PATCH 2/2] IB/mlx4: Return EAGAIN for any error in mlx4_ib_poll_one

[Yuval Shaia]

Error code EAGAIN should be used when errors are temporary and next call
might succeeds.
When error code other than EAGAIN is returned, the caller (mlx4_ib_poll)
will assume all CQE in the same bunch are error too and will drop them all.

Signed-off-by: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
 drivers/infiniband/hw/mlx4/cq.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/infiniband/hw/mlx4/cq.c b/drivers/infiniband/hw/mlx4/cq.c
index 4c2e1b0..4516282 100644
--- a/drivers/infiniband/hw/mlx4/cq.c
+++ b/drivers/infiniband/hw/mlx4/cq.c
@@ -690,7 +690,7 @@ repoll:
 	if (unlikely((cqe->owner_sr_opcode & MLX4_CQE_OPCODE_MASK) == MLX4_OPCODE_NOP &&
 		     is_send)) {
 		pr_warn("Completion for NOP opcode detected!\n");
-		return -EINVAL;
+		return -EAGAIN;
 	}
 
 	/* Resize CQ in progress */
@@ -721,7 +721,7 @@ repoll:
 		if (unlikely(!mqp)) {
 			pr_warn("CQ %06x with entry for unknown QPN %06x\n",
 			       cq->mcq.cqn, be32_to_cpu(cqe->vlan_my_qpn) & MLX4_CQE_QPN_MASK);
-			return -EINVAL;
+			return -EAGAIN;
 		}
 
 		*cur_qp = to_mibqp(mqp);
@@ -739,7 +739,7 @@ repoll:
 		if (unlikely(!msrq)) {
 			pr_warn("CQ %06x with entry for unknown SRQN %06x\n",
 				cq->mcq.cqn, srq_num);
-			return -EINVAL;
+			return -EAGAIN;
 		}
 	}
 
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: IB/mlx4: Use EAGAIN error code instead or EINVAL in function mlx4_ib_poll_one

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

On Wed, Jul 27, 2016 at 01:24:51AM -0700, Yuval Shaia wrote:
> Please review the following two patches.
> First patch makes int-return function to a void one as it anyway returns 0.
> Second patch replace all EINVAL error codes returned from mlx4_ib_poll_one
> to EAGAIN.

Thanks Yuval for taking time to do it.
After your's IPoIB patches, we prepared patch similar to these and
planned to send it after merge window will close.

> 
> [PATCH 1/2] IB/mlx4: Make function use_tunnel_data return void
> [PATCH 2/2] IB/mlx4: Return EAGAIN for any error in mlx4_ib_poll_one
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: IB/mlx4: Use EAGAIN error code instead or EINVAL in function mlx4_ib_poll_one

[Yuval Shaia]

On Wed, Jul 27, 2016 at 11:58:00AM +0300, Leon Romanovsky wrote:
> On Wed, Jul 27, 2016 at 01:24:51AM -0700, Yuval Shaia wrote:
> > Please review the following two patches.
> > First patch makes int-return function to a void one as it anyway returns 0.
> > Second patch replace all EINVAL error codes returned from mlx4_ib_poll_one
> > to EAGAIN.
> 
> Thanks Yuval for taking time to do it.
> After your's IPoIB patches, we prepared patch similar to these and
> planned to send it after merge window will close.

Great new!
So, will you also take care of making the function use_tunnel_data void?

> 
> > 
> > [PATCH 1/2] IB/mlx4: Make function use_tunnel_data return void
> > [PATCH 2/2] IB/mlx4: Return EAGAIN for any error in mlx4_ib_poll_one
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: IB/mlx4: Use EAGAIN error code instead or EINVAL in function mlx4_ib_poll_one

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]

On Wed, Jul 27, 2016 at 01:26:41PM +0300, Yuval Shaia wrote:
> On Wed, Jul 27, 2016 at 11:58:00AM +0300, Leon Romanovsky wrote:
> > On Wed, Jul 27, 2016 at 01:24:51AM -0700, Yuval Shaia wrote:
> > > Please review the following two patches.
> > > First patch makes int-return function to a void one as it anyway returns 0.
> > > Second patch replace all EINVAL error codes returned from mlx4_ib_poll_one
> > > to EAGAIN.
> > 
> > Thanks Yuval for taking time to do it.
> > After your's IPoIB patches, we prepared patch similar to these and
> > planned to send it after merge window will close.
> 
> Great new!
> So, will you also take care of making the function use_tunnel_data void?

No problem, I'll resubmit your use_tunnel_data patch.
Thanks

> 
> > 
> > > 
> > > [PATCH 1/2] IB/mlx4: Make function use_tunnel_data return void
> > > [PATCH 2/2] IB/mlx4: Return EAGAIN for any error in mlx4_ib_poll_one
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: IB/mlx4: Use EAGAIN error code instead or EINVAL in function mlx4_ib_poll_one

[Yuval Shaia]

On Wed, Jul 27, 2016 at 02:23:29PM +0300, Leon Romanovsky wrote:
> On Wed, Jul 27, 2016 at 01:26:41PM +0300, Yuval Shaia wrote:
> > On Wed, Jul 27, 2016 at 11:58:00AM +0300, Leon Romanovsky wrote:
> > > On Wed, Jul 27, 2016 at 01:24:51AM -0700, Yuval Shaia wrote:
> > > > Please review the following two patches.
> > > > First patch makes int-return function to a void one as it anyway returns 0.
> > > > Second patch replace all EINVAL error codes returned from mlx4_ib_poll_one
> > > > to EAGAIN.
> > > 
> > > Thanks Yuval for taking time to do it.
> > > After your's IPoIB patches, we prepared patch similar to these and
> > > planned to send it after merge window will close.
> > 
> > Great new!
> > So, will you also take care of making the function use_tunnel_data void?
> 
> No problem, I'll resubmit your use_tunnel_data patch.
> Thanks

With the surrounding {} please :)
I can send v1 if needed.

> 
> > 
> > > 
> > > > 
> > > > [PATCH 1/2] IB/mlx4: Make function use_tunnel_data return void
> > > > [PATCH 2/2] IB/mlx4: Return EAGAIN for any error in mlx4_ib_poll_one
> > > > --
> > > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> > 


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: IB/mlx4: Use EAGAIN error code instead or EINVAL in function mlx4_ib_poll_one

[Leon Romanovsky]

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

On Wed, Jul 27, 2016 at 02:42:39PM +0300, Yuval Shaia wrote:
> On Wed, Jul 27, 2016 at 02:23:29PM +0300, Leon Romanovsky wrote:
> > On Wed, Jul 27, 2016 at 01:26:41PM +0300, Yuval Shaia wrote:
> > > On Wed, Jul 27, 2016 at 11:58:00AM +0300, Leon Romanovsky wrote:
> > > > On Wed, Jul 27, 2016 at 01:24:51AM -0700, Yuval Shaia wrote:
> > > > > Please review the following two patches.
> > > > > First patch makes int-return function to a void one as it anyway returns 0.
> > > > > Second patch replace all EINVAL error codes returned from mlx4_ib_poll_one
> > > > > to EAGAIN.
> > > > 
> > > > Thanks Yuval for taking time to do it.
> > > > After your's IPoIB patches, we prepared patch similar to these and
> > > > planned to send it after merge window will close.
> > > 
> > > Great new!
> > > So, will you also take care of making the function use_tunnel_data void?
> > 
> > No problem, I'll resubmit your use_tunnel_data patch.
> > Thanks
> 
> With the surrounding {} please :)
> I can send v1 if needed.

There is no need, I already added correct version to our verification
system.

Thanks

> 
> > 
> > > 
> > > > 
> > > > > 
> > > > > [PATCH 1/2] IB/mlx4: Make function use_tunnel_data return void
> > > > > [PATCH 2/2] IB/mlx4: Return EAGAIN for any error in mlx4_ib_poll_one
> > > > > --
> > > > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > > > > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > > > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > > 
> > > 
> 
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]