From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB/hfi1: Allow for non-double word multiple message sizes for user SDMA
Date: Thu, 28 Jul 2016 10:58:40 +0300 [thread overview]
Message-ID: <20160728075840.GN4628@leon.nu> (raw)
In-Reply-To: <20160728010842.GC3158-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 935 bytes --]
On Wed, Jul 27, 2016 at 09:08:42PM -0400, ira.weiny wrote:
>
> The driver pads non-double word multiple message sizes but it doesn't
> account for this padding when the packet length is calculated. Also, the
> data length is miscalculated for message sizes less than 4 bytes due to
> the bit representation in LRH. And there's a check for non-double word
> multiple message sizes that prevents these messages from being sent.
> This patch fixes length miscalculations and enables the functionality to
> send non-double word multiple message sizes.
>
> Reviewed-by: Harish Chegondi <harish.chegondi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Sebastian Sanchez <sebastian.sanchez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
Ira,
Is this sizeof(u32) really necessary? It is always the same 4 bytes in
all architectures.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-28 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 1:08 [PATCH] IB/hfi1: Allow for non-double word multiple message sizes for user SDMA ira.weiny
[not found] ` <20160728010842.GC3158-W4f6Xiosr+yv7QzWx2u06xL4W9x8LtSr@public.gmane.org>
2016-07-28 7:58 ` Leon Romanovsky [this message]
[not found] ` <20160728075840.GN4628-2ukJVAZIZ/Y@public.gmane.org>
2016-07-28 16:35 ` ira.weiny
2016-08-03 2:49 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160728075840.GN4628@leon.nu \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).