Re: [PATCH] IB/hfi1: Allow for non-double word multiple message sizes for user SDMA

["ira.weiny" <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]

On Thu, Jul 28, 2016 at 10:58:40AM +0300, Leon Romanovsky wrote:
> On Wed, Jul 27, 2016 at 09:08:42PM -0400, ira.weiny wrote:
> > 
> > The driver pads non-double word multiple message sizes but it doesn't
> > account for this padding when the packet length is calculated. Also, the
> > data length is miscalculated for message sizes less than 4 bytes due to
> > the bit representation in LRH. And there's a check for non-double word
> > multiple message sizes that prevents these messages from being sent.
> > This patch fixes length miscalculations and enables the functionality to
> > send non-double word multiple message sizes.
> > 
> > Reviewed-by: Harish Chegondi <harish.chegondi-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Sebastian Sanchez <sebastian.sanchez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > ---
> 
> Ira,
> Is this sizeof(u32) really necessary? It is always the same 4 bytes in
> all architectures.

Yes, using the magic number 4 would work but I don't think it really matters
either way.

Ira

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html