From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Jay Freyensee
<james_p_freyensee-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Jens Axboe <axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
Subject: Re: [PATCH 4/5] nvme-rdma: Remove duplicate call to nvme_remove_namespaces
Date: Mon, 1 Aug 2016 13:06:04 +0200 [thread overview]
Message-ID: <20160801110604.GE16141@lst.de> (raw)
In-Reply-To: <1469822242-3477-5-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
> - nvme_remove_namespaces(&ctrl->ctrl);
> - nvme_rdma_shutdown_ctrl(ctrl);
> nvme_uninit_ctrl(&ctrl->ctrl);
> + nvme_rdma_shutdown_ctrl(ctrl);
How safe is the reordering here? The description should explain why
it's fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-01 11:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-29 19:57 [PATCH 0/5] Some fabrics fixes Sagi Grimberg
[not found] ` <1469822242-3477-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-07-29 19:57 ` [PATCH 1/5] nvme-rdma: Fix device removal handling Sagi Grimberg
[not found] ` <1469822242-3477-2-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-01 11:00 ` Christoph Hellwig
2016-07-29 19:57 ` [PATCH 2/5] nvme-rdma: Free the I/O tags when we delete the controller Sagi Grimberg
[not found] ` <1469822242-3477-3-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-01 11:03 ` Christoph Hellwig
[not found] ` <20160801110308.GC16141-jcswGhMUV9g@public.gmane.org>
2016-08-01 11:15 ` Sagi Grimberg
[not found] ` <c2c194b0-d0a1-11af-cae9-a4ce8ea8fdde-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-01 15:47 ` Christoph Hellwig
[not found] ` <20160801154717.GA22771-jcswGhMUV9g@public.gmane.org>
2016-08-02 6:14 ` Sagi Grimberg
2016-07-29 19:57 ` [PATCH 3/5] nvme-rdma: Make sure to shutdown the controller if we can Sagi Grimberg
[not found] ` <1469822242-3477-4-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-01 11:04 ` Christoph Hellwig
[not found] ` <20160801110446.GD16141-jcswGhMUV9g@public.gmane.org>
2016-08-01 11:17 ` Sagi Grimberg
[not found] ` <63b33585-3fd2-a497-94a1-34dc9484da99-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-01 15:48 ` Christoph Hellwig
[not found] ` <20160801154840.GB22771-jcswGhMUV9g@public.gmane.org>
2016-08-02 6:19 ` Sagi Grimberg
[not found] ` <cf6b0293-aba9-1a6f-28f2-3754b2eec4af-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-02 12:52 ` Christoph Hellwig
[not found] ` <20160802125257.GD13235-jcswGhMUV9g@public.gmane.org>
2016-08-02 13:26 ` Sagi Grimberg
2016-07-29 19:57 ` [PATCH 4/5] nvme-rdma: Remove duplicate call to nvme_remove_namespaces Sagi Grimberg
[not found] ` <1469822242-3477-5-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-01 11:06 ` Christoph Hellwig [this message]
[not found] ` <20160801110604.GE16141-jcswGhMUV9g@public.gmane.org>
2016-08-01 11:21 ` Sagi Grimberg
2016-07-29 19:57 ` [PATCH 5/5] nvme-loop: " Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801110604.GE16141@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=james_p_freyensee-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).