From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Roland Dreier <roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Jens Axboe <axboe-b10kYP2dOMg@public.gmane.org>,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] nvme-rdma: Don't leak uninitialized memory in connect request private data
Date: Mon, 1 Aug 2016 13:07:44 +0200 [thread overview]
Message-ID: <20160801110744.GG16141@lst.de> (raw)
In-Reply-To: <1469950060-18098-1-git-send-email-roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Sun, Jul 31, 2016 at 12:27:39AM -0700, Roland Dreier wrote:
> From: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
>
> Zero out the full nvme_rdma_cm_req structure before sending it.
> Otherwise we end up leaking kernel memory in the reserved field, which
> might break forward compatibility in the future.
>
> Signed-off-by: Roland Dreier <roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>
Looks fine,
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-08-01 11:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 7:27 [PATCH 1/2] nvme-rdma: Don't leak uninitialized memory in connect request private data Roland Dreier
[not found] ` <1469950060-18098-1-git-send-email-roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-07-31 7:27 ` [PATCH 2/2] nvme-rdma: Add handling for connecting to IPv6 targets Roland Dreier
[not found] ` <1469950060-18098-2-git-send-email-roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-07-31 8:45 ` Sagi Grimberg
[not found] ` <4acdd466-b8f6-8208-7287-e97dfd45bbf1-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-07-31 10:58 ` Sagi Grimberg
[not found] ` <33dfc646-1804-363e-4d83-1ba618303dbb-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-07-31 15:33 ` Roland Dreier
[not found] ` <CAL1RGDUHrvQWXxHgxsK78WWT+Mr1uB2LFAVGi8-bHf1n5vCJDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-01 5:58 ` Sagi Grimberg
[not found] ` <333b4d7a-d93b-daa9-7abd-108db5c534e4-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-01 6:15 ` Sagi Grimberg
2016-08-01 11:09 ` Christoph Hellwig
[not found] ` <20160801110956.GI16141-jcswGhMUV9g@public.gmane.org>
2016-08-01 11:24 ` Sagi Grimberg
[not found] ` <e6e54d3f-c6ee-2057-d4e5-13981cd95140-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-01 15:50 ` Christoph Hellwig
[not found] ` <20160801155036.GC22771-jcswGhMUV9g@public.gmane.org>
2016-08-01 16:06 ` Roland Dreier
[not found] ` <CAG4TOxPNnUKWeh7FUY8YB127sx8yMu41FuP4hxUMCan_HWQmVQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-02 6:43 ` Sagi Grimberg
2016-08-18 7:44 ` Sagi Grimberg
[not found] ` <2b4f4727-58b5-c62e-e5fd-cc5e5b4ae6be-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-22 4:44 ` Roland Dreier
[not found] ` <CAG4TOxO9RY+h_Pwa1qtdrm3BRKvr7eDrD-tz-D1=uxY2LcpqWw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-22 6:47 ` Sagi Grimberg
2016-08-02 12:51 ` Christoph Hellwig
2016-08-02 6:41 ` Sagi Grimberg
2016-08-01 11:09 ` Christoph Hellwig
2016-07-31 8:44 ` [PATCH 1/2] nvme-rdma: Don't leak uninitialized memory in connect request private data Sagi Grimberg
2016-08-01 11:07 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801110744.GG16141@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=axboe-b10kYP2dOMg@public.gmane.org \
--cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).