From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v3] nvmet-rdma: Correctly handle RDMA device hot removal Date: Mon, 1 Aug 2016 17:50:54 +0200 Message-ID: <20160801155054.GD22771@lst.de> References: <1469967347-20466-1-git-send-email-sagi@grimberg.me> <20160801111530.GB16474@lst.de> <307087d1-88af-5244-38e8-5b9786285488@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <307087d1-88af-5244-38e8-5b9786285488-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg Cc: Christoph Hellwig , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jay Freyensee , Ming Lin , Steve Wise List-Id: linux-rdma@vger.kernel.org On Mon, Aug 01, 2016 at 02:30:37PM +0300, Sagi Grimberg wrote: >> How is ->remove_port synchronized vs the RDMA/CM even handler? > > Easy, it isn't :) > > So we have three choices here: > 1. Add a lock in nvmet_port that only rdma will use for now (don't like > it) > or > 2. Add nvmet_rdma_port as nvmet_port->priv with a lock (don't like it) > or > 3. take the global nvmet_config_sem (hate it) > > Any preferences? (4) use cmpxchg? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html