From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jay Freyensee
<james_p_freyensee-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Ming Lin <mlin-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Subject: Re: [PATCH v3] nvmet-rdma: Correctly handle RDMA device hot removal
Date: Tue, 2 Aug 2016 14:53:48 +0200 [thread overview]
Message-ID: <20160802125348.GE13235@lst.de> (raw)
In-Reply-To: <dc6286c3-a5c0-48a8-284d-f53b6830da22-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
On Tue, Aug 02, 2016 at 09:39:48AM +0300, Sagi Grimberg wrote:
> I'm not exactly sure what you mean. Do you mean placing
> cmpxchg in nvmet_rdma_device_removal()? To what we cmp
> when we want to xchg?
>
> Care to explain in a bit more detail?
Right, plain xchg() should be enough. E.g. do an xchg both
in the device removal handler and ->remove_port and only delete
the CM_ID if the caller was the one taking it out the private
data.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-02 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-31 12:15 [PATCH v3] nvmet-rdma: Correctly handle RDMA device hot removal Sagi Grimberg
[not found] ` <1469967347-20466-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-01 11:15 ` Christoph Hellwig
[not found] ` <20160801111530.GB16474-jcswGhMUV9g@public.gmane.org>
2016-08-01 11:30 ` Sagi Grimberg
[not found] ` <307087d1-88af-5244-38e8-5b9786285488-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-01 15:50 ` Christoph Hellwig
[not found] ` <20160801155054.GD22771-jcswGhMUV9g@public.gmane.org>
2016-08-02 6:39 ` Sagi Grimberg
[not found] ` <dc6286c3-a5c0-48a8-284d-f53b6830da22-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-02 12:53 ` Christoph Hellwig [this message]
2016-08-01 14:44 ` Bart Van Assche
[not found] ` <7b8cc595-a33c-99e6-8490-161f83c2c489-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-08-01 15:09 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802125348.GE13235@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=james_p_freyensee-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mlin-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox