From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v3] nvmet-rdma: Correctly handle RDMA device hot removal Date: Tue, 2 Aug 2016 14:53:48 +0200 Message-ID: <20160802125348.GE13235@lst.de> References: <1469967347-20466-1-git-send-email-sagi@grimberg.me> <20160801111530.GB16474@lst.de> <307087d1-88af-5244-38e8-5b9786285488@grimberg.me> <20160801155054.GD22771@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg Cc: Christoph Hellwig , linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jay Freyensee , Ming Lin , Steve Wise List-Id: linux-rdma@vger.kernel.org On Tue, Aug 02, 2016 at 09:39:48AM +0300, Sagi Grimberg wrote: > I'm not exactly sure what you mean. Do you mean placing > cmpxchg in nvmet_rdma_device_removal()? To what we cmp > when we want to xchg? > > Care to explain in a bit more detail? Right, plain xchg() should be enough. E.g. do an xchg both in the device removal handler and ->remove_port and only delete the CM_ID if the caller was the one taking it out the private data. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html