From: Steven Rostedt <rostedt@goodmis.org>
To: Steve Wise <swise@opengridcomputing.com>
Cc: 'Baole Ni' <baolex.ni@intel.com>,
swise@chelsio.com, dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, airlied@linux.ie, kgene@kernel.org,
k.kozlowski@samsung.com, dougthompson@xmission.com, bp@alien8.de,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
chuansheng.liu@intel.com, hch@infradead.org, matanb@mellanox.com,
markb@mellanox.com, jgunthorpe@obsidianresearch.com,
dean.luick@intel.com
Subject: Re: [PATCH 0254/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 11:08:32 -0400 [thread overview]
Message-ID: <20160802150832.GA26697@home.goodmis.org> (raw)
In-Reply-To: <006201d1ecc7$f6889bd0$e399d370$@opengridcomputing.com>
On Tue, Aug 02, 2016 at 09:12:54AM -0500, Steve Wise wrote:
> Acked-by: Steve Wise <swise@opengridcomputing.com>
>
I have to ask, why did you ack all these? There's several things wrong with
this patch series, but even the point of the patch is mistaken. It makes
readable code much less readable. When you chmod a file, do you type
chmod 0444 file
or do you write
chmod S_IRUSR|S_IRGRP|S_IROTH file
?
Which of the above is easier to figure what is being changed?
Not to mention, because the subject is the same for all 1285 patches, and you
deleted the content of the patch in your ack, there's no way to know what
exactly this ack is for (I haven't received the original patch yet because
it's probably being ratelimited by some mail server).
-- Steve
next prev parent reply other threads:[~2016-08-02 15:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 10:53 [PATCH 0254/1285] Replace numeric parameter like 0444 with macro Baole Ni
[not found] ` <20160802105341.30676-1-baolex.ni-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-02 14:12 ` Steve Wise
2016-08-02 15:08 ` Steven Rostedt [this message]
[not found] ` <20160802150832.GA26697-UXXpqIVMmUvGOoBxVeW/qg@public.gmane.org>
2016-08-02 15:20 ` Steve Wise
2016-08-02 15:44 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802150832.GA26697@home.goodmis.org \
--to=rostedt@goodmis.org \
--cc=airlied@linux.ie \
--cc=baolex.ni@intel.com \
--cc=bp@alien8.de \
--cc=chuansheng.liu@intel.com \
--cc=dean.luick@intel.com \
--cc=dledford@redhat.com \
--cc=dougthompson@xmission.com \
--cc=hal.rosenstock@gmail.com \
--cc=hch@infradead.org \
--cc=jgunthorpe@obsidianresearch.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markb@mellanox.com \
--cc=matanb@mellanox.com \
--cc=sean.hefty@intel.com \
--cc=swise@chelsio.com \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox