From: Leon Romanovsky <leon@kernel.org>
To: Baole Ni <baolex.ni@intel.com>
Cc: faisal.latif@intel.com, dledford@redhat.com,
sean.hefty@intel.com, hal.rosenstock@gmail.com, bp@alien8.de,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
chuansheng.liu@intel.com, hch@infradead.org, matanb@mellanox.com,
markb@mellanox.com, jgunthorpe@obsidianresearch.com,
dean.luick@intel.com
Subject: Re: [PATCH 0266/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 21:52:47 +0300 [thread overview]
Message-ID: <20160802185247.GC27667@leon.nu> (raw)
In-Reply-To: <20160802105446.31475-1-baolex.ni@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1525 bytes --]
On Tue, Aug 02, 2016 at 06:54:46PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
Looks good,
Reviewed-By: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/hw/nes/nes_hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/nes/nes_hw.c b/drivers/infiniband/hw/nes/nes_hw.c
> index a1c6481..f25c37f 100644
> --- a/drivers/infiniband/hw/nes/nes_hw.c
> +++ b/drivers/infiniband/hw/nes/nes_hw.c
> @@ -41,7 +41,7 @@
> #include "nes.h"
>
> static int wide_ppm_offset;
> -module_param(wide_ppm_offset, int, 0644);
> +module_param(wide_ppm_offset, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
> MODULE_PARM_DESC(wide_ppm_offset, "Increase CX4 interface clock ppm offset, 0=100ppm (default), 1=300ppm");
>
> static u32 crit_err_count;
> --
> 2.9.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-08-02 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 10:54 [PATCH 0266/1285] Replace numeric parameter like 0444 with macro Baole Ni
2016-08-02 18:52 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802185247.GC27667@leon.nu \
--to=leon@kernel.org \
--cc=baolex.ni@intel.com \
--cc=bp@alien8.de \
--cc=chuansheng.liu@intel.com \
--cc=dean.luick@intel.com \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=hal.rosenstock@gmail.com \
--cc=hch@infradead.org \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markb@mellanox.com \
--cc=matanb@mellanox.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).