From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH v2 5/5] nvme-rdma: Make sure to shutdown the controller if we can Date: Wed, 3 Aug 2016 11:04:06 +0200 Message-ID: <20160803090406.GD11321@lst.de> References: <1470124419-30405-1-git-send-email-sagi@grimberg.me> <1470124419-30405-6-git-send-email-sagi@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1470124419-30405-6-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Christoph Hellwig , Steve Wise , Jay Freyensee , Ming Lin List-Id: linux-rdma@vger.kernel.org On Tue, Aug 02, 2016 at 10:53:39AM +0300, Sagi Grimberg wrote: > Relying on ctrl state in nvme_rdma_shutdown_ctrl is wrong because > it will never be NVME_CTRL_LIVE (delete_ctrl or reset_ctrl invoked it). > > Instead, check that the admin queue is connected. Note that it is safe > because we can never see a copmeting thread trying to destroy the admin > queue (reset or delete controller). > > Signed-off-by: Sagi Grimberg Looks fine, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html