From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] nvmet-rdma: Don't use the inline buffer in order to avoid allocation for small reads Date: Thu, 4 Aug 2016 13:49:38 +0200 Message-ID: <20160804114938.GA32487@lst.de> References: <1470040599-7294-1-git-send-email-sagi@grimberg.me> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1470040599-7294-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sagi Grimberg Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jens Axboe , Christoph Hellwig , Steve Wise , Jay Freyensee , Ming Lin List-Id: linux-rdma@vger.kernel.org On Mon, Aug 01, 2016 at 11:36:39AM +0300, Sagi Grimberg wrote: > Under extreme conditions this might cause data corruptions. By doing that > we we repost the buffer and then post this buffer for the device to send. > If we happen to use shared receive queues the device might write to the > buffer before it sends it (there is no ordering between send and recv > queues). Without SRQs we probably won't get that if the host doesn't > mis-behave and send more than we allowed it, but relying on that is not > really a good idea. Allright, after the discussion: Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html