From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Cc: linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
Ming Lin <mlin-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jay Freyensee
<james_p_freyensee-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Steve Wise
<swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
Subject: Re: [PATCH v4] nvmet-rdma: Correctly handle RDMA device hot removal
Date: Thu, 4 Aug 2016 13:50:05 +0200 [thread overview]
Message-ID: <20160804115005.GB32487@lst.de> (raw)
In-Reply-To: <1470230393-23671-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
On Wed, Aug 03, 2016 at 04:19:53PM +0300, Sagi Grimberg wrote:
> When configuring a device attached listener, we may
> see device removal events. In this case we return a
> non-zero return code from the cm event handler which
> implicitly destroys the cm_id. It is possible that in
> the future the user will remove this listener and by
> that trigger a second call to rdma_destroy_id on an
> already destroyed cm_id -> BUG.
>
> In addition, when a queue bound (active session) cm_id
> generates a DEVICE_REMOVAL event we must guarantee all
> resources are cleaned up by the time we return from the
> event handler.
>
> Introduce nvmet_rdma_device_removal which addresses
> (or at least attempts to) both scenarios.
>
> Signed-off-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Looks fine,
Reviewed-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-08-04 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 13:19 [PATCH v4] nvmet-rdma: Correctly handle RDMA device hot removal Sagi Grimberg
[not found] ` <1470230393-23671-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-08-04 11:50 ` Christoph Hellwig [this message]
2016-08-16 13:11 ` [PATCH] nvmet-rdma: Fix use after free Vincent Stehlé
2016-08-16 13:17 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804115005.GB32487@lst.de \
--to=hch-jcswghmuv9g@public.gmane.org \
--cc=james_p_freyensee-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=linux-nvme-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mlin-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
--cc=swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox