From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Wei Yongjun <weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Lijun Ou <oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
"Wei Hu(Xavier)"
<xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Hal Rosenstock
<hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH -next] IB/hns: Fix return value check in hns_roce_get_cfg()
Date: Sun, 7 Aug 2016 16:14:19 +0300 [thread overview]
Message-ID: <20160807131419.GS27667@leon.nu> (raw)
In-Reply-To: <087f4381-d830-fc57-ea5d-c516a1b160b5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
On Sun, Aug 07, 2016 at 08:19:39PM +0800, Wei Yongjun wrote:
> On 08/07/2016 01:31 PM, Leon Romanovsky wrote:
> > On Sat, Aug 06, 2016 at 01:01:24AM +0000, Wei Yongjun wrote:
> >> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> >> and never returns NULL. The NULL test in the return value check should
> >> be replaced with IS_ERR().
> >>
> >> Signed-off-by: Wei Yongjun <weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > On which branch did you base your patch?
> > It would be helpful to us if you followed SubmittionPatches document,
> > section with Fixes description. In such case "git describe" will give
> > immediate answer on my first question.
> >
> This patch is based on the linux-next.git tree.
> Fixes: 5e43122add63 ('IB/hns: Add driver files for hns RoCE driver')
This driver wasn't part of last pull request and it is worth to consult
with Doug Ledford on the plans for this driver (stay in ->next, resubmit
e.t.c).
Right now, there is no tree to apply this patch.
Thanks
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-08-07 13:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-06 1:01 [PATCH -next] IB/hns: Fix return value check in hns_roce_get_cfg() Wei Yongjun
[not found] ` <1470445284-28970-1-git-send-email-weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-07 5:31 ` Leon Romanovsky
[not found] ` <20160807053115.GQ27667-2ukJVAZIZ/Y@public.gmane.org>
2016-08-07 12:19 ` Wei Yongjun
[not found] ` <087f4381-d830-fc57-ea5d-c516a1b160b5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-08-07 13:14 ` Leon Romanovsky [this message]
[not found] ` <20160807131419.GS27667-2ukJVAZIZ/Y@public.gmane.org>
2016-08-11 10:43 ` Wei Hu (Xavier)
[not found] ` <57AC56D4.3050401-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-08-22 18:15 ` Doug Ledford
[not found] ` <c27a3c5f-9604-546a-5ac7-e70613d93d50-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-08-23 1:56 ` Wei Hu (Xavier)
[not found] ` <57BBAD65.6000108-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-08-23 10:59 ` Leon Romanovsky
[not found] ` <20160823105926.GG15065-2ukJVAZIZ/Y@public.gmane.org>
2016-08-24 1:22 ` Wei Hu (Xavier)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160807131419.GS27667@leon.nu \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=weiyj.lk-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=xavier.huwei-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox