Re: [PATCH libmlx5] fix err return values to match ibv_post_send expectations

Jarod Wilson
2016-08-06T18:48:23Z

On Fri, Aug 05, 2016 at 12:01:07PM -0600, Jason Gunthorpe wrote:
> On Fri, Aug 05, 2016 at 01:33:59PM -0400, Jarod Wilson wrote:
> > - return _mlx5_post_send(ibqp, wr, bad_wr);
> > + errno = _mlx5_post_send(ibqp, wr, bad_wr);
> > + return errno;
>
> Why still set errno? It was wrong in the first place..
>
> Likely every use of errno in this provider should be reviewed.

Wasn't sure if something else might actually consume errno elsewhere,
since it's a global, and the other code path in that function set errno.
Could certainly just stick with returning the _mlx5_post_send() result
directly.

--
Jarod Wilson
jarod-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org