Re: [PATCH] IB/hfi1: Fetch monitor values on-demand for CableInfo query

Dalessandro, Dennis
2016-08-10T19:07:12Z

On Wed, 2016-08-10 at 08:51 +0300, Leon Romanovsky wrote:
> On Wed, Aug 10, 2016 at 01:35:50AM -0400, ira.weiny wrote:
> > On Tue, Aug 09, 2016 at 08:58:01PM +0300, Leon Romanovsky wrote:
> > > On Tue, Aug 09, 2016 at 11:17:18AM -0400, ira.weiny@intel.com
> > > wrote:
> > > > From: Easwar Hariharan <easwar.hariharan@intel.com>
> > > >
> > > > The monitor values from bytes 22 through 81 of the QSFP memory
> > > > space
> > > > (SFF 8636) are dynamic and serving them out of the QSFP memory
> > > > cache
> > > > maintained by the driver provides stale data to the CableInfo
> > > > SMA query.
> > > > This patch refreshes the dynamic values from the QSFP memory on
> > > > request
> > > > and overwrites the stale data from the cache for the overlap
> > > > between the
> > > > requested range and the monitor range.
> > > >
> > > >
> > >
> > > Ira,
> > > On all your patches, you have double line between commit message
> > > and
> > > tags.
> >
> > Does this cause a problem?
>
> Problem - no, inconvenience - yes.
> It doesn't look pretty in git history.

We'll catch it next time? Not worth resubmitting I don't think.

-Denny