Re: [PATCH rdma-next 4/6] RDMA/core: Move HFI1 IOCTL declarations to common file

Leon Romanovsky
2016-08-17T14:16:13Z

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

On Wed, Aug 17, 2016 at 01:35:53PM +0000, Dalessandro, Dennis wrote:
> On Wed, 2016-08-17 at 09:55 +0300, Leon Romanovsky wrote:
> > On Wed, Aug 17, 2016 at 02:16:31AM -0400, ira.weiny wrote:
> > > On Tue, Aug 16, 2016 at 04:45:21PM +0300, Leon Romanovsky wrote:
> > > > From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > > >
> > > > Move HFI1 IOCTL declarations to rdma_user_ioctl.h file.
> > >
> > > I have not tried with the patch but I'm 99% sure this will break
> > > the PSM2
> > > library build which includes hfi1_user.h.
> > >
> > > This is one of those things I have pondered in the past.  Most of
> > > the rdma
> > > libraries don't actually use these definitions directly.  PSM2
> > > does.
> >
> > I'm not so convinced about it.
> > "#include <rdma/rdma_user_ioctl.h>" was added to hfi1_user.h to share
> > all definitions. PSM2 library will see it.
>
> On face value that should be true. I would want to run it by the PSM
> folks and test it out though to be sure.

I agree,
Thanks.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]