Re: [PATCH rdma-next 6/6] RDMA/core: Unify style of IOCTL commands

Dalessandro, Dennis
2016-08-17T13:45:21Z

On Wed, 2016-08-17 at 08:19 +0300, Leon Romanovsky wrote:

> > I'm not opposed to trying to unify things, however this seems to be
> > more than plop down the hfi1 stuff from here and put it over there.
> > It
> > is certainly not simplifying anything.
>
> It is "dark side" of UAPI - inability to change legacy declarations.
> This is why I didn't remove anything except _NUM() macro.
>
> The simplification comes from definition of one place for
> declaration of IOCTLs numbers and exporting it to users. It gives
> visibility for user space authors too.

How often does a user need the IOCTL numbers for MAD and PSM and
whatever else we come up with at the same time? Why would they care
about the other IOCTL numbers?

I don't really see a problem with keeping them separate, but I'm not
really opposed to collapsing into one place either.

-Denny