On Thu, Aug 18, 2016 at 02:08:20PM +0300, Yuval Shaia wrote: > On Tue, Aug 16, 2016 at 04:45:17PM +0300, Leon Romanovsky wrote: > > Hi Doug, > > > > This patch set refactors RDMA IOCTL declarations, unifies their > > location, moves all current IOCTL exporters to one place and renames > > them to fix the differences in coding style. > > > > IOCTLs commands need to export the size of their data for their transfer > > which is usually declared as a struct defined in relevant submodule. > > These structures should be visible at the linkage stage. > > Just for my understanding - this is not an issue only with RDMA-IOCTLs, > right? > (Wondering how other modules approaches this). I'm not familiar with all subsystems, but IMHO, we will find all possible solutions. While working on the patches, I took a look on other subsystems and they exposed structures in the same file as IOCTLs from the day one.