Re: [PATCH 17/22] IB/mlx4/mad: Remove deprecated create_singlethread_workqueue

Leon Romanovsky
2016-08-19T15:50:25Z

[-- Attachment #1: Type: text/plain, Size: 1981 bytes --]

On Mon, Aug 15, 2016 at 11:43:10PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
>
> The workqueue "wq" queues work item &ctx->work and the workqueue "ud_wq"
> queues work item &dm[i]->work.
>
> Both the workqueues have been identity converted.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Thanks,
Reviewed-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

> ---
> drivers/infiniband/hw/mlx4/mad.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c
> index 9c2e53d..35b1260 100644
> --- a/drivers/infiniband/hw/mlx4/mad.c
> +++ b/drivers/infiniband/hw/mlx4/mad.c
> @@ -2070,7 +2070,7 @@ static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev,
> }
>
> snprintf(name, sizeof name, "mlx4_ibt%d", port);
> - ctx->wq = create_singlethread_workqueue(name);
> + ctx->wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
> if (!ctx->wq) {
> pr_err("Failed to create tunnelling WQ for port %d\n", port);
> ret = -ENOMEM;
> @@ -2078,7 +2078,7 @@ static int mlx4_ib_alloc_demux_ctx(struct mlx4_ib_dev *dev,
> }
>
> snprintf(name, sizeof name, "mlx4_ibud%d", port);
> - ctx->ud_wq = create_singlethread_workqueue(name);
> + ctx->ud_wq = alloc_ordered_workqueue(name, WQ_MEM_RECLAIM);
> if (!ctx->ud_wq) {
> pr_err("Failed to create up/down WQ for port %d\n", port);
> ret = -ENOMEM;
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]