Re: [PATCH 14/22] IB/mlx5: Remove deprecated create_singlethread_workqueue

Leon Romanovsky
2016-08-19T15:44:18Z

[-- Attachment #1: Type: text/plain, Size: 1557 bytes --]

On Mon, Aug 15, 2016 at 11:41:18PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set, replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
>
> The workqueue "cache->wq" queues work items &ent->work (maps to
> cache_work_func) and &ent->dwork(maps to delayed_cache_work_func).
> It has been identity converted.
>
> WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> drivers/infiniband/hw/mlx5/mr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Thanks,
Acked-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

>
> diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c
> index 8cf2ce5..fb0194d 100644
> --- a/drivers/infiniband/hw/mlx5/mr.c
> +++ b/drivers/infiniband/hw/mlx5/mr.c
> @@ -614,7 +614,7 @@ int mlx5_mr_cache_init(struct mlx5_ib_dev *dev)
> int err;
> int i;
>
> - cache->wq = create_singlethread_workqueue("mkey_cache");
> + cache->wq = alloc_ordered_workqueue("mkey_cache", WQ_MEM_RECLAIM);
> if (!cache->wq) {
> mlx5_ib_warn(dev, "failed to create work queue\n");
> return -ENOMEM;
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]