From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
To: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: move unsafe global rkey handling to the RDMA core
Date: Mon, 29 Aug 2016 10:42:55 -0600 [thread overview]
Message-ID: <20160829164255.GD23557@obsidianresearch.com> (raw)
In-Reply-To: <1472464943-29450-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
On Mon, Aug 29, 2016 at 12:02:17PM +0200, Christoph Hellwig wrote:
> This fairly simply series adds support to ib_alloc_pd to create the unsafe
> global rkey in the IB core, and then switches over all ULPs to use that
> functionality instead of using ib_get_dma_mr directly, and consequently
> removes ib_get_dma_mr now that all global registrations are done in the
> core code.
>
> The advantage is that abuses of ib_get_dma_mr are more easily prevented,
> and use of the global unsafe rkey is more visible and auditable.
>
> I'm also pondering removing the get_dma_mr methods and moving the global
> registrations into the ->alloc_pd methods, but I'll need to investigate
> how that will work out first.
This looks good to me:
Reviewed-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-08-29 16:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 10:02 move unsafe global rkey handling to the RDMA core Christoph Hellwig
[not found] ` <1472464943-29450-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-08-29 10:02 ` [PATCH 1/6] IB/core: rename pd->local_mr to pd->__internal_mr Christoph Hellwig
[not found] ` <1472464943-29450-2-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-08-29 15:26 ` Steve Wise
2016-08-29 15:32 ` Steve Wise
2016-08-30 15:32 ` Sagi Grimberg
2016-08-29 10:02 ` [PATCH 2/6] IB/core: add support to create a unsafe global rkey to ib_create_pd Christoph Hellwig
[not found] ` <1472464943-29450-3-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-08-29 15:27 ` Steve Wise
2016-08-29 15:32 ` Steve Wise
2016-08-30 15:32 ` Sagi Grimberg
2016-08-29 10:02 ` [PATCH 3/6] IB/iser: use IB_PD_UNSAFE_GLOBAL_RKEY Christoph Hellwig
[not found] ` <1472464943-29450-4-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-08-29 15:28 ` Steve Wise
2016-08-30 15:33 ` Sagi Grimberg
2016-08-29 10:02 ` [PATCH 4/6] IB/srp: " Christoph Hellwig
[not found] ` <1472464943-29450-5-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-08-29 15:29 ` Steve Wise
2016-08-29 17:00 ` Bart Van Assche
[not found] ` <df613e79-7c01-5fa6-5586-6f567254224b-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2016-08-30 12:47 ` Christoph Hellwig
[not found] ` <20160830124705.GA7585-jcswGhMUV9g@public.gmane.org>
2016-08-30 15:35 ` Sagi Grimberg
2016-08-31 9:32 ` Max Gurtovoy
[not found] ` <bb2a15be-8a22-d889-5eb6-c0f315465507-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-09-05 10:24 ` Christoph Hellwig
2016-08-29 10:02 ` [PATCH 5/6] nvme-rdma: " Christoph Hellwig
[not found] ` <1472464943-29450-6-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-08-29 15:30 ` Steve Wise
2016-08-30 15:35 ` Sagi Grimberg
[not found] ` <148fd046-c239-a416-8409-202661e19876-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2016-09-05 10:34 ` Christoph Hellwig
2016-08-29 10:02 ` [PATCH 6/6] IB/core: remove ib_get_dma_mr Christoph Hellwig
[not found] ` <1472464943-29450-7-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2016-08-29 15:32 ` Steve Wise
2016-08-30 15:36 ` Sagi Grimberg
2016-08-29 16:42 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829164255.GD23557@obsidianresearch.com \
--to=jgunthorpe-epgobjl8dl3ta4ec/59zmfatqe2ktcn/@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hch-jcswGhMUV9g@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).