linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yuval Shaia <yuval.shaia-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: Adit Ranadive <aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
	jhansen-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
	asarwade-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
	georgezhang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org,
	bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org
Subject: Re: [PATCH v3 12/15] IB/pvrdma: Add the main driver module for PVRDMA
Date: Thu, 1 Sep 2016 19:54:05 +0300	[thread overview]
Message-ID: <20160901165404.GA3429@yuval-lap.mynet> (raw)
In-Reply-To: <1470266864-16888-13-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>

On Wed, Aug 03, 2016 at 04:27:41PM -0700, Adit Ranadive wrote:
+
> +	/* Activate pvrdma device */
> +	pvrdma_write_reg(dev, PVRDMA_REG_CTL, PVRDMA_DEVICE_CTL_ACTIVATE);
> +
> +	/* Make sure the write is complete before reading status. */
> +	mb();
> +
> +	/* Check if device was successfully activated */
> +	ret = pvrdma_read_reg(dev, PVRDMA_REG_ERR);
> +	if (ret != 0) {
> +		dev_err(&pdev->dev, "failed to activate device\n");
> +		ret = -EINVAL;
> +		goto err_disable_intr;
> +	}

What if it will take the device to activate longer than the time between
write to PVRDMA_DEVICE_CTL_ACTIVATE and read from PVRDMA_REG_ERR?

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2016-09-01 16:54 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-03 23:27 [PATCH v3 00/15] Add Paravirtual RDMA Driver Adit Ranadive
     [not found] ` <1470266864-16888-1-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-03 23:27   ` [PATCH v3 01/15] IB/pvrdma: Add user-level shared functions Adit Ranadive
     [not found]     ` <1470266864-16888-2-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-21 11:24       ` Yuval Shaia
     [not found]         ` <20160821112436.GA22012-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-09-06 18:58           ` Adit Ranadive
2016-08-03 23:27   ` [PATCH v3 02/15] IB/pvrdma: Add virtual device RDMA structures Adit Ranadive
     [not found]     ` <1470266864-16888-3-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-21 11:54       ` Yuval Shaia
     [not found]         ` <20160821115441.GB22012-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-08-23 17:46           ` Adit Ranadive
     [not found]             ` <BLUPR0501MB836ACEAF51DF69E5623EBF5C5EB0-84Rf5TRaNBMVDhIuTCx1aJLWcSx1hRipwIZJ9u9yWa8oOQlpcoRfSA@public.gmane.org>
2016-08-25  6:03               ` Yuval Shaia
2016-09-06 19:03                 ` Adit Ranadive
2016-08-03 23:27   ` [PATCH v3 03/15] IB/pvrdma: Add the paravirtual RDMA device specification Adit Ranadive
     [not found]     ` <1470266864-16888-4-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-10 16:51       ` Leon Romanovsky
2016-08-03 23:27   ` [PATCH v3 04/15] IB/pvrdma: Add functions for Verbs support Adit Ranadive
     [not found]     ` <1470266864-16888-5-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-23 15:13       ` Yuval Shaia
2016-08-23 18:43         ` Leon Romanovsky
     [not found]           ` <20160823184322.GM15065-2ukJVAZIZ/Y@public.gmane.org>
2016-08-23 18:52             ` Adit Ranadive
     [not found]               ` <BLUPR0501MB836B1C542C1296616A05080C5EB0-84Rf5TRaNBMVDhIuTCx1aJLWcSx1hRipwIZJ9u9yWa8oOQlpcoRfSA@public.gmane.org>
2016-08-23 20:56                 ` Leon Romanovsky
2016-08-23 19:07             ` Doug Ledford
2016-08-25  7:30       ` Yuval Shaia
2016-09-07 17:00         ` Adit Ranadive
     [not found]           ` <BLUPR0501MB836F2A8282244C2821DC346C5F80-84Rf5TRaNBMVDhIuTCx1aJLWcSx1hRipwIZJ9u9yWa8oOQlpcoRfSA@public.gmane.org>
2016-09-08  8:38             ` Yuval Shaia
     [not found]               ` <20160908083800.GA7760-Hxa29pjIrESt9MVyvc/JHg@public.gmane.org>
2016-09-08 18:34                 ` Adit Ranadive
2016-08-03 23:27   ` [PATCH v3 05/15] IB/pvrdma: Add paravirtual rdma device Adit Ranadive
     [not found]     ` <1470266864-16888-6-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-25  9:59       ` Yuval Shaia
     [not found]         ` <20160825095920.GB14419-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-08-28 13:06           ` Leon Romanovsky
     [not found]             ` <20160828130657.GM594-2ukJVAZIZ/Y@public.gmane.org>
2016-08-28 13:41               ` Yuval Shaia
2016-08-28 13:50                 ` Leon Romanovsky
     [not found]                   ` <20160828135048.GO594-2ukJVAZIZ/Y@public.gmane.org>
2016-08-28 15:50                     ` Adit Ranadive
2016-08-29 13:59       ` Yuval Shaia
2016-08-03 23:27   ` [PATCH v3 06/15] IB/pvrdma: Add helper functions Adit Ranadive
     [not found]     ` <1470266864-16888-7-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-25  6:16       ` Yuval Shaia
2016-08-25  6:29         ` Yuval Shaia
2016-08-29 12:08       ` Yuval Shaia
2016-09-07 19:26         ` Adit Ranadive
2016-08-03 23:27   ` [PATCH v3 07/15] IB/pvrdma: Add device command support Adit Ranadive
     [not found]     ` <1470266864-16888-8-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-04  4:30       ` Leon Romanovsky
2016-08-25 10:08       ` Yuval Shaia
2016-08-03 23:27   ` [PATCH v3 08/15] IB/pvrdma: Add support for Completion Queues Adit Ranadive
     [not found]     ` <1470266864-16888-9-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-25 12:41       ` Yuval Shaia
     [not found]         ` <20160825124120.GB27446-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-09-07 17:25           ` Adit Ranadive
     [not found]             ` <BLUPR0501MB83629470B22B65E27B4332AC5F80-84Rf5TRaNBMVDhIuTCx1aJLWcSx1hRipwIZJ9u9yWa8oOQlpcoRfSA@public.gmane.org>
2016-09-08  8:18               ` Yuval Shaia
     [not found]                 ` <20160908081802.GA3300-Hxa29pjIrESt9MVyvc/JHg@public.gmane.org>
2016-09-08 18:26                   ` Adit Ranadive
     [not found]                     ` <BLUPR0501MB836A35B3F4B839B1E2055A8C5FB0-84Rf5TRaNBMVDhIuTCx1aJLWcSx1hRipwIZJ9u9yWa8oOQlpcoRfSA@public.gmane.org>
2016-09-08 18:46                       ` Jason Gunthorpe
     [not found]                         ` <20160908184608.GG21614-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-09-08 18:56                           ` Adit Ranadive
2016-08-03 23:27   ` [PATCH v3 09/15] IB/pvrdma: Add UAR support Adit Ranadive
     [not found]     ` <1470266864-16888-10-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-10  3:54       ` Leon Romanovsky
2016-08-25 13:13       ` Yuval Shaia
2016-08-03 23:27   ` [PATCH v3 10/15] IB/pvrdma: Add support for memory regions Adit Ranadive
     [not found]     ` <1470266864-16888-11-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-25 14:15       ` Yuval Shaia
     [not found]         ` <20160825141505.GD27446-Hxa29pjIrETlQW142y8m19+IiqhCXseY@public.gmane.org>
2016-09-07 19:06           ` Adit Ranadive
2016-08-03 23:27   ` [PATCH v3 11/15] IB/pvrdma: Add Queue Pair support Adit Ranadive
     [not found]     ` <1470266864-16888-12-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-10  4:16       ` Leon Romanovsky
2016-08-29 14:44       ` Yuval Shaia
2016-09-07 19:33         ` Adit Ranadive
2016-08-03 23:27   ` [PATCH v3 12/15] IB/pvrdma: Add the main driver module for PVRDMA Adit Ranadive
     [not found]     ` <1470266864-16888-13-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-04  6:53       ` Leon Romanovsky
     [not found]         ` <20160804065352.GJ27667-2ukJVAZIZ/Y@public.gmane.org>
2016-08-04 19:18           ` Adit Ranadive
2016-09-01 13:20       ` Yuval Shaia
     [not found]         ` <20160901132024.GA26356-Hxa29pjIrESt9MVyvc/JHg@public.gmane.org>
2016-09-07 19:41           ` Adit Ranadive
     [not found]             ` <BLUPR0501MB836EF38D944CD38F8897C07C5F80-84Rf5TRaNBMVDhIuTCx1aJLWcSx1hRipwIZJ9u9yWa8oOQlpcoRfSA@public.gmane.org>
2016-09-08 15:25               ` Yuval Shaia
     [not found]                 ` <20160908152541.GA3352-Hxa29pjIrESt9MVyvc/JHg@public.gmane.org>
2016-09-08 18:40                   ` Adit Ranadive
2016-09-01 16:54       ` Yuval Shaia [this message]
     [not found]         ` <20160901165404.GA3429-Hxa29pjIrESt9MVyvc/JHg@public.gmane.org>
2016-09-07 20:19           ` Adit Ranadive
2016-08-03 23:27   ` [PATCH v3 13/15] IB/pvrdma: Add Kconfig and Makefile Adit Ranadive
2016-08-03 23:27   ` [PATCH v3 14/15] IB: Add PVRDMA driver Adit Ranadive
     [not found]     ` <1470266864-16888-15-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-04  2:30       ` kbuild test robot
2016-08-06  5:34       ` kbuild test robot
2016-08-03 23:27   ` [PATCH v3 15/15] MAINTAINERS: Update for " Adit Ranadive
     [not found]     ` <1470266864-16888-16-git-send-email-aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org>
2016-08-30 13:17       ` Yuval Shaia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160901165404.GA3429@yuval-lap.mynet \
    --to=yuval.shaia-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
    --cc=aditr-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    --cc=asarwade-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    --cc=bryantan-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=georgezhang-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    --cc=jhansen-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=pv-drivers-pghWNbHTmq7QT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).